Skip to content

(fix) have the buffer reader call wrapped in a try catch in case of exception #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2018
Merged

(fix) have the buffer reader call wrapped in a try catch in case of exception #241

merged 2 commits into from
Nov 29, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

Summary

  • A customer found an exception when BuilderVersion is being read. It seems to be an class initialization issue. So, we are wrapping it in a try catch and logging the error before returning version unknown.

The "why", or other context.

Test plan

No additional tests were written.

Issues

  • customer found issue

@coveralls
Copy link

coveralls commented Nov 26, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 778

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 89.917%
Totals Coverage Status
Change from base Build 776: 0.007%
Covered Lines: 2693
Relevant Lines: 2995
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit ab053a8 into master Nov 29, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the fixExceptionBuilerVersion branch November 29, 2018 17:29
thomaszurkan-optimizely added a commit that referenced this pull request Dec 6, 2018
@thomaszurkan-optimizely
have the buffer reader call wrapped in a try catch in case of excepti…
9fe19b7 
…on (#241)
thomaszurkan-optimizely added a commit that referenced this pull request Dec 7, 2018
@thomaszurkan-optimizely
(chore):Fix2.1.5 (#245)
921e0d9 
* have the buffer reader call wrapped in a try catch in case of exception (#241)

* update changelog for patch release (#244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@mjc1283 mjc1283 Awaiting requested review from mjc1283

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @coveralls @mikeproeng37