Skip to content

(chore): update changelog for patch release #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Dec 6, 2018

Summary

  • prepare for 2.1.4 patch release wrapping load file in try/catch.

The "why", or other context.

Test plan

Issues

There was a crash reported here effecting a very small group.

@thomaszurkan-optimizely thomaszurkan-optimizely changed the title update changelog for patch release chore: update changelog for patch release Dec 6, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely changed the title chore: update changelog for patch release (chore): update changelog for patch release Dec 6, 2018
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 733faa5 into master Dec 6, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the prepare2.1.4 branch December 6, 2018 22:16
thomaszurkan-optimizely added a commit that referenced this pull request Dec 7, 2018
* have the buffer reader call wrapped in a try catch in case of exception (#241)

* update changelog for patch release (#244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants