Skip to content

Commit ab053a8

Browse files
have the buffer reader call wrapped in a try catch in case of exception (#241)
1 parent 8e3dafc commit ab053a8

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

core-api/src/main/java/com/optimizely/ab/event/internal/BuildVersionInfo.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,22 @@ public final class BuildVersionInfo {
3737

3838
public final static String VERSION = readVersionNumber();
3939
private static String readVersionNumber() {
40-
BufferedReader bufferedReader =
41-
new BufferedReader(
42-
new InputStreamReader(BuildVersionInfo.class.getResourceAsStream("/optimizely-build-version"),
43-
Charset.forName("UTF-8")));
40+
BufferedReader bufferedReader = null;
4441
try {
42+
bufferedReader =
43+
new BufferedReader(
44+
new InputStreamReader(BuildVersionInfo.class.getResourceAsStream("/optimizely-build-version"),
45+
Charset.forName("UTF-8")));
46+
4547
return bufferedReader.readLine();
4648
} catch (Exception e) {
4749
logger.error("unable to read version number");
4850
return "unknown";
4951
} finally {
5052
try {
51-
bufferedReader.close();
53+
if (bufferedReader != null) {
54+
bufferedReader.close();
55+
}
5256
} catch (Exception e) {
5357
logger.error("unable to close reader cleanly");
5458
}

0 commit comments

Comments
 (0)