-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ helm: use chunking release driver in systemNamespace #1057
⚠️ helm: use chunking release driver in systemNamespace #1057
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
=======================================
Coverage 75.28% 75.28%
=======================================
Files 33 35 +2
Lines 1861 1914 +53
=======================================
+ Hits 1401 1441 +40
- Misses 321 330 +9
- Partials 139 143 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1e74ae0
to
1508461
Compare
1508461
to
06bed04
Compare
011246e
to
e11beca
Compare
e11beca
to
3ef23ce
Compare
bf02ec0
to
1a7068f
Compare
1a7068f
to
457fc3f
Compare
457fc3f
to
695725b
Compare
695725b
to
f45ace5
Compare
f45ace5
to
45cfc21
Compare
45cfc21
to
bebe28c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks reasonable to me
(Added a comment later about a TODO though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I want the TODO in there about the timeout.
I would prefer a release of helm-operator-plugins, failing that, perhaps a TODO.
bebe28c
to
526f0c9
Compare
And... a rebase is needed... |
526f0c9
to
c9a604c
Compare
Ok, rebased and reverted the catalog client timeout change, so it is back to 10s. Looks like e2e still passes in GH CI. I'm also seeing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
c9a604c
to
30c827a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…ork#1057) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
…ork#1057) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Description
This PR:
helm-operator-plugins
that chunks release data into one or more secrets (this also incidentally means that our client and the Helm CLI client won't mistake each other's release storage for their own).Fixes: #923
Reviewer Checklist