✨ Wire up Service Account #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
- Coverage 72.50% 72.25% -0.26%
==========================================
Files 32 32
Lines 1884 1903 +19
==========================================
+ Hits 1366 1375 +9
- Misses 383 389 +6
- Partials 135 139 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
openshift-merge-robot
added
the
needs-rebase
joelanford
reviewed
Jul 16, 2024
| cfgGetter, err := helmclient.NewActionConfigGetter(mgr.GetConfig(), mgr.GetRESTMapper(), | ||
| helmclient.StorageNamespaceMapper(installNamespaceMapper), | ||
| helmclient.ClientNamespaceMapper(installNamespaceMapper), | ||
| helmclient.RestConfigMapper(restConfigMapper), |
There was a problem hiding this comment.
If this lands soon, all good. But just wanted to let you know that I'm working on making REST config mapping handle storage and client interactions separately. The intent is that we would use our own service account for storage (since that is an implementation detail of our controller) and we would only use the ClusterExtension's service account for the helm client's REST config.
See:
There was a problem hiding this comment.
Thanks for the heads up! I spoke with @theishshah and I think we will focus on getting this in using the soon-to-be-deprecated RestConfigMapper option and as a follow up address this (if the helm-operator-plugins changes land before this gets in)
openshift-merge-robot
added
needs-rebase
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Ish Shah <ishah@redhat.com>
Comment on lines
+120
to
+121
| //+kubebuilder:rbac:groups=core,resources=serviceaccounts/token,verbs=create | ||
| //+kubebuilder:rbac:groups=apiextensions.k8s.io,resources=customresourcedefinitions,verbs=get |
There was a problem hiding this comment.
For other reviewers, the serviceaccounts/token permissions were required to get tokens for a provided SA and the customresourcedefinitions permissions are for the CRD Upgrade Safety preflight checks
everettraven
approved these changes
Jul 18, 2024
Merged
via the queue into
operator-framework:main
with commit Jul 18, 2024
95b9f0d
16 of 18 checks passed
joelanford
added a commit
to joelanford/operator-controller
that referenced
this pull request
Jul 19, 2024
This reverts commit 95b9f0d.
4 tasks
This was referenced Jul 19, 2024
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
* add logic to return service account Signed-off-by: Ish Shah <ishah@redhat.com> * update permissions and anon token Signed-off-by: Ish Shah <ishah@redhat.com> * updated role yaml Signed-off-by: Ish Shah <ishah@redhat.com> * clean up imports Signed-off-by: Ish Shah <ishah@redhat.com> * update e2e tests Signed-off-by: Ish Shah <ishah@redhat.com> * fix lint Signed-off-by: Ish Shah <ishah@redhat.com> * extension developer test fixed Signed-off-by: Ish Shah <ishah@redhat.com> * stand up sa for upgrade test Signed-off-by: Ish Shah <ishah@redhat.com> * fixed upgrade test Signed-off-by: Ish Shah <ishah@redhat.com> * linting for extension test Signed-off-by: Ish Shah <ishah@redhat.com> --------- Signed-off-by: Ish Shah <ishah@redhat.com>
perdasilva
pushed a commit
to kevinrizza/operator-controller
that referenced
this pull request
Aug 13, 2024
* add logic to return service account Signed-off-by: Ish Shah <ishah@redhat.com> * update permissions and anon token Signed-off-by: Ish Shah <ishah@redhat.com> * updated role yaml Signed-off-by: Ish Shah <ishah@redhat.com> * clean up imports Signed-off-by: Ish Shah <ishah@redhat.com> * update e2e tests Signed-off-by: Ish Shah <ishah@redhat.com> * fix lint Signed-off-by: Ish Shah <ishah@redhat.com> * extension developer test fixed Signed-off-by: Ish Shah <ishah@redhat.com> * stand up sa for upgrade test Signed-off-by: Ish Shah <ishah@redhat.com> * fixed upgrade test Signed-off-by: Ish Shah <ishah@redhat.com> * linting for extension test Signed-off-by: Ish Shah <ishah@redhat.com> --------- Signed-off-by: Ish Shah <ishah@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#973 Add functionality to use Service Account