✨ Remove unpacked status #1309
✨ Remove unpacked status #1309
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
==========================================
- Coverage 76.58% 76.34% -0.24%
==========================================
Files 40 40
Lines 2413 2389 -24
==========================================
- Hits 1848 1824 -24
Misses 397 397
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| require.NoError(t, cl.DeleteAllOf(ctx, &ocv1alpha1.ClusterExtension{})) |
There was a problem hiding this comment.
This seems reasonable to keep around - I must've been a bit heavy handed on my removal of logic in this test and removed this
skattoju
force-pushed
the
remove_unpacked
branch
2 times, most recently
from
5cdbd9d
to
325ddf2
Compare
skattoju
force-pushed
the
remove_unpacked
branch
from
325ddf2
to
75c07f5
Compare
There was a problem hiding this comment.
Changes look good to me! Thanks @skattoju !
CI also looks green except for go-apidiff which has the expected failure
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
There is an e2e failure in the merge queue but it passes locally 🤔 and its not in a function that had an unpacked condition removed.. specifically |
40ada4a
Description
This PR removes the "Unpacked" status which has now been rolled into a "Progressing" status.
Fixes #1294
Reviewer Checklist