Skip to content

Conversation

josefkarasek
Copy link
Contributor

Signed-off-by: Josef Karasek jkarasek@redhat.com

Signed-off-by: Josef Karasek <jkarasek@redhat.com>
@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josefkarasek, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to not ensure group is present?

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
@josefkarasek
Copy link
Contributor Author

any reason to not ensure group is present?

group is rarely present

Sometimes we can find something like apiVersion: operators.coreos.com/v1alpha1

@estroz
Copy link
Member

estroz commented Sep 3, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit c9b1e7e into operator-framework:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants