-
Notifications
You must be signed in to change notification settings - Fork 260
Validate bundles in opm index add -b <bundles>
#754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate bundles in opm index add -b <bundles>
#754
Conversation
This change pulls bundle images from `-b` and runs the following checks: * bundle format is correct * bundle content is correct (CSV, CRD, Type/ObjectMeta) Signed-off-by: Josef Karasek <jkarasek@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josefkarasek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @josefkarasek. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -0,0 +1,279 @@ | |||
#! parse-kind: ClusterServiceVersion | |||
kind: ClusterServiceVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APIVersion
intentionally missing
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
+ Coverage 50.24% 50.42% +0.17%
==========================================
Files 101 102 +1
Lines 8691 8728 +37
==========================================
+ Hits 4367 4401 +34
- Misses 3471 3474 +3
Partials 853 853
Continue to review full report at Codecov.
|
Added: * Prometheus manifests where CSV is missing `APIVersion` * Test case which expects `opm index add` with the invalid manifests to fail Signed-off-by: Josef Karasek <jkarasek@redhat.com>
eebd7a6
to
2bfbe25
Compare
Signed-off-by: Josef Karasek <jkarasek@redhat.com>
Closing in favor of operator-framework/api#152 |
This change pulls bundle images from
-b
and runs the following checks:Signed-off-by: Josef Karasek jkarasek@redhat.com
Description of the change:
This change pulls bundle images from
-b
and runs the following checks:Motivation for the change:
Bug reported by a user
Reviewer Checklist
/docs