Skip to content

Conversation

josefkarasek
Copy link

This change pulls bundle images from -b and runs the following checks:

  • bundle format is correct
  • bundle content is correct (CSV, CRD, Type/ObjectMeta)

Signed-off-by: Josef Karasek jkarasek@redhat.com

Description of the change:
This change pulls bundle images from -b and runs the following checks:

  • bundle format is correct
  • bundle content is correct (CSV, CRD, Type/ObjectMeta)

Motivation for the change:
Bug reported by a user

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

This change pulls bundle images from `-b` and runs the following checks:
* bundle format is correct
* bundle content is correct (CSV, CRD, Type/ObjectMeta)

Signed-off-by: Josef Karasek <jkarasek@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josefkarasek
To complete the pull request process, please assign ecordell after the PR has been reviewed.
You can assign the PR to them by writing /assign @ecordell in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

Hi @josefkarasek. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2021
@@ -0,0 +1,279 @@
#! parse-kind: ClusterServiceVersion
kind: ClusterServiceVersion
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APIVersion intentionally missing

@josefkarasek
Copy link
Author

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #754 (6612664) into master (9960109) will increase coverage by 0.17%.
The diff coverage is 81.01%.

❗ Current head 6612664 differs from pull request most recent head 0072711. Consider uploading reports for the commit 0072711 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   50.24%   50.42%   +0.17%     
==========================================
  Files         101      102       +1     
  Lines        8691     8728      +37     
==========================================
+ Hits         4367     4401      +34     
- Misses       3471     3474       +3     
  Partials      853      853              
Impacted Files Coverage Δ
alpha/action/generate_dockerfile.go 81.81% <ø> (ø)
alpha/action/init.go 100.00% <ø> (ø)
alpha/action/list.go 67.70% <ø> (ø)
alpha/declcfg/declcfg.go 100.00% <ø> (ø)
alpha/declcfg/declcfg_to_model.go 76.19% <ø> (ø)
alpha/declcfg/load.go 83.56% <ø> (ø)
alpha/declcfg/model_to_declcfg.go 100.00% <ø> (ø)
alpha/declcfg/properties.go 100.00% <ø> (ø)
alpha/declcfg/write.go 71.69% <ø> (ø)
alpha/model/error.go 100.00% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9960109...0072711. Read the comment docs.

Added:
* Prometheus manifests where CSV is missing `APIVersion`
* Test case which expects `opm index add` with the invalid manifests to fail

Signed-off-by: Josef Karasek <jkarasek@redhat.com>
Signed-off-by: Josef Karasek <jkarasek@redhat.com>
@josefkarasek
Copy link
Author

Closing in favor of operator-framework/api#152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants