Skip to content

Add validation for Kind and APIVersion #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Add validation for Kind and APIVersion #152

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1526750
Add validation for Kind and APIVersion
Sep 2, 2021
30ef921
Update pkg/validation/internal/csv.go
josefkarasek Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/validation/internal/csv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ func validateCSV(csv *v1alpha1.ClusterServiceVersion) errors.ManifestResult {
result.Add(checkFields(*csv)...)
// validate case sensitive annotation names
result.Add(ValidateAnnotationNames(csv.GetAnnotations(), csv.GetName())...)
// validate Version and Kind
result.Add(validateVersionKind(csv)...)
return result
}

Expand Down Expand Up @@ -194,3 +196,15 @@ func validateInstallModes(csv *v1alpha1.ClusterServiceVersion) (errs []errors.Er
}
return errs
}

// validateVersionKind checks presense of GroupVersionKind.Verion and GroupVersionKind.Kind
func validateVersionKind(csv *v1alpha1.ClusterServiceVersion) (errs []errors.Error) {
gvk := csv.GroupVersionKind()
if gvk.Version == "" {
errs = append(errs, errors.ErrInvalidCSV("'apiVersion' is missing", csv.GetName()))
}
if gvk.Kind == "" {
errs = append(errs, errors.ErrInvalidCSV("'kind' is missing", csv.GetName()))
}
return
}