-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: DidCommV2: Sync with the main branch #1541
chore: DidCommV2: Sync with the main branch #1541
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
…t-foundation#1451) Signed-off-by: Martin Auer <martin.auer97@gmail.com>
…-foundation#1462) Signed-off-by: Dheeraj Budhiraja <dheeraj.budhiraja@wipro.com>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ndation#1481) Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.2.2 to 4.2.4. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](https://github.com/NaturalIntelligence/fast-xml-parser/commits) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ion#1482) Signed-off-by: Charles Lanahan <charles.lanahan@gmail.com>
…n#1477) Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Timo Glastra <timo@animo.id>
…foundation#1488) Signed-off-by: Martin Auer <martin.auer97@gmail.com>
…on#1508) Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Signed-off-by: Ry Jones <ry@linux.com> Signed-off-by: Ankur Banerjee <ankurdotb@users.noreply.github.com>
…ndation#1513) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dation#1516) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
…enwallet-foundation#1514) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…llet-foundation#1515) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n#1509) Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
…dation#1511) Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
…llet-foundation#1517) Signed-off-by: Martin Auer <martin.auer97@gmail.com>
…#1535) Signed-off-by: Ariel Gentile <gentilester@gmail.com>
…ping message Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
…Unified MessageSender Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
…ility Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
…c-main # Conflicts: # demo/src/Faber.ts # packages/askar/tests/askar-postgres.e2e.test.ts # packages/bbs-signatures/package.json # packages/core/src/agent/AgentMessage.ts # packages/core/src/agent/MessageSender.ts # packages/core/src/agent/TransportService.ts # packages/core/src/crypto/index.ts # packages/core/src/decorators/attachment/v1/Attachment.ts # packages/core/src/modules/connections/ConnectionsApi.ts # packages/core/src/modules/connections/DidExchangeProtocol.ts # packages/core/src/modules/connections/__tests__/ConnectionService.test.ts # packages/core/src/modules/connections/services/ConnectionService.ts # packages/core/src/modules/dids/domain/DidDocument.ts # packages/core/src/modules/oob/OutOfBandApi.ts # packages/core/src/modules/oob/protocols/v1/OutOfBandService.ts # packages/core/src/modules/oob/repository/OutOfBandRecord.ts # packages/core/src/modules/proofs/ProofsApi.ts # packages/core/src/storage/didcomm/DidCommMessageRecord.ts # packages/core/src/storage/didcomm/DidCommMessageRepository.ts # packages/core/src/utils/parseInvitation.ts # packages/core/tests/oob.test.ts # tests/transport/SubjectInboundTransport.ts
…#1538) Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
…c-main # Conflicts: # packages/askar/src/wallet/AskarBaseWallet.ts # packages/core/src/types.ts
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
…comm-v2-sync-main # Conflicts: # packages/askar/src/wallet/AskarWallet.ts # packages/bbs-signatures/src/BbsModule.ts # packages/bbs-signatures/tests/bbs-signatures.e2e.test.ts # packages/core/src/agent/TransportService.ts # packages/core/src/crypto/__tests__/JwsService.test.ts # packages/core/src/crypto/index.ts # packages/core/src/decorators/attachment/v1/Attachment.ts # packages/core/src/didcomm/versions/v1/DidCommV1Message.ts # packages/core/src/didcomm/versions/v2/DidCommV2Message.ts # packages/core/src/modules/connections/DidExchangeProtocol.ts # packages/core/src/modules/connections/__tests__/ConnectionService.test.ts # packages/core/src/modules/vc/__tests__/W3cCredentialService.test.ts # packages/indy-sdk/src/wallet/IndySdkWallet.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job @Artemkaaas ! I have some issues when running the tests locally: one of them is solved just by fixing the path as suggested, while the others seem to be related to mediated/connection-less interactions using indy-sdk.
Summary of all failing tests
FAIL packages/core/src/modules/connections/__tests__/ConnectionService.test.ts
Cannot find module '../../oob/OutOfBandService' from 'src/modules/connections/__tests__/ConnectionService.test.ts'
> 55 | jest.mock('../../oob/OutOfBandService')
FAIL packages/core/tests/connections.test.ts (21.032 s)
● connections › agent using mediator should be able to make multiple connections using a multi use invite
WalletError: Error unpacking message
at IndySdkWallet.unpackDidCommV1 (../indy-sdk/src/wallet/IndySdkWallet.ts:609:13)
● connections › agent using mediator should be able to make multiple connections using a multi use invite
● connections › agent using mediator should be able to make multiple connections using a multi use invite
FAIL packages/anoncreds/src/protocols/proofs/v1/__tests__/v1-connectionless-proofs.e2e.test.ts (48.378 s)
IndySdkWallet.unpackDidCommV1
● V1 Proofs - Connectionless - Indy › Faber starts with connection-less proof requests to Alice with auto-accept enabled and both agents having a mediator
FAIL packages/core/src/modules/proofs/protocol/v2/__tests__/v2-indy-connectionless-proofs.e2e.test.ts (75.266 s)
● V2 Connectionless Proofs - Indy › Faber starts with connection-less proof requests to Alice with auto-accept enabled and both agents having a mediator
WalletError: Error unpacking message
at IndySdkWallet.unpackDidCommV1 (../indy-sdk/src/wallet/IndySdkWallet.ts:609:13)
● V2 Connectionless Proofs - Indy › Faber starts with connection-less proof requests to Alice with auto-accept enabled and both agents having a mediator
FAIL packages/core/tests/oob-mediation.test.ts (21.093 s)
● out of band with mediation › make a connection with https://didcomm.org/didexchange/1.0 on OOB invitation encoded in URL
WalletError: Error unpacking message
at IndySdkWallet.unpackDidCommV1 (../indy-sdk/src/wallet/IndySdkWallet.ts:609:13)
● out of band with mediation › make a connection with https://didcomm.org/didexchange/1.0 on OOB invitation encoded in URL
FAIL packages/core/src/modules/routing/__tests__/mediation.test.ts (61.63 s)
● mediator establishment › Mediation end-to-end flow
WalletError: Error unpacking message
at IndySdkWallet.unpackDidCommV1 (../indy-sdk/src/wallet/IndySdkWallet.ts:609:13)
at MessageReceiver.receiveEncryptedMessage (src/agent/MessageReceiver.ts:140:29)
at MessageReceiver.receiveMessage (src/agent/MessageReceiver.ts:113:16)
at Object.next (../../tests/transport/SubjectInboundTransport.ts:51:9)
● mediator establishment › Mediation end-to-end flow
● mediator establishment › Mediation end-to-end flow (not using did:key)
WalletError: Error unpacking message
at IndySdkWallet.unpackDidCommV1 (../indy-sdk/src/wallet/IndySdkWallet.ts:609:13)
● mediator establishment › Mediation end-to-end flow (not using did:key)
● mediator establishment › restart recipient agent and create connection through mediator after recipient agent is restarted
WalletError: Error unpacking message
at IndySdkWallet.unpackDidCommV1 (../indy-sdk/src/wallet/IndySdkWallet.ts:609:13)
● mediator establishment › restart recipient agent and create connection through mediator after recipient agent is restarted
FAIL packages/core/tests/oob-mediation-provision.test.ts (21.45 s)
● out of band with mediation set up with provision method › make a connection with https://didcomm.org/didexchange/1.0 on OOB invitation encoded in URL
WalletError: Error unpacking message
at IndySdkWallet.unpackDidCommV1 (../indy-sdk/src/wallet/IndySdkWallet.ts:609:13)
● out of band with mediation set up with provision method › make a connection with https://didcomm.org/didexchange/1.0 on OOB invitation encoded in URL
FAIL tests/e2e-ws-pickup-v2.test.ts (24.139 s)
● E2E WS Pickup V2 tests › Full WS flow (connect, request mediation, issue, verify) using Message Pickup V2
FAIL tests/e2e-subject.test.ts (28.902 s)
● E2E Subject tests › Full Subject flow (connect, request mediation, issue, verify)
WalletError: Error unpacking message
at IndySdkWallet.unpackDidCommV1 (../packages/indy-sdk/src/wallet/IndySdkWallet.ts:609:13)
● E2E Subject tests › Full Subject flow (connect, request mediation, issue, verify)
FAIL tests/e2e-http.test.ts (21.6 s)
● E2E HTTP tests › Full HTTP flow (connect, request mediation, issue, verify)
FAIL tests/e2e-ws.test.ts (21.769 s)
● E2E WS tests › Full WS flow (connect, request mediation, issue, verify)
● E2E WS tests › Full WS flow (connect, request mediation, issue, verify)
MessageSendingError: Unable to resolve DID Document for 'did:peer:1zQmVKRJ2VcmMjUCouoeQX81sqvLpSzEBg2tdzmTJcZ4xgJZ
Cause:
AriesFrameworkError: Unable to resolve did document for did 'did:peer:1zQmVKRJ2VcmMjUCouoeQX81sqvLpSzEBg2tdzmTJcZ4xgJZ': notFound resolver_error: Unable to resolve did 'did:peer:1zQmVKRJ2VcmMjUCouoeQX81sqvLpSzEBg2tdzmTJcZ4xgJZ': IndySdkError: Searching 'DidRecord' records for query '{"did":"did:peer:1zQmVKRJ2VcmMjUCouoeQX81sqvLpSzEBg2tdzmTJcZ4xgJZ"}' failed: AriesFrameworkError(undefined): Wallet has not been initialized yet. Make sure to await agent.initialize() before using the agent.
64 |
65 | if (!didDocument) {
> 66 | throw new AriesFrameworkError(`Unable to resolve did document for did '${did}': ${error} ${message}`)
| ^
67 | }
68 | return didDocument
69 | }
at DidResolverService.resolveDidDocument (../packages/core/src/modules/dids/services/DidResolverService.ts:66:13)
at MessageSender.sendMessage (../packages/core/src/agent/MessageSender.ts:286:24)
at MessagePickupApi.pickupMessages (../packages/core/src/modules/message-pìckup/MessagePickupApi.ts:89:5)
at Object.next (../packages/core/src/modules/routing/MediationRecipientApi.ts:262:15)
FAIL packages/tenants/tests/tenant-sessions.e2e.test.ts (131.921 s)
● Tenants Sessions E2E › create 100 sessions in parallel for the same tenant and close them
● Tenants Sessions E2E › create 5 sessions each for 20 tenants in parallel and close them
AriesFrameworkError: Failed to acquire an agent context session within 10000ms
Were you aware of these issues with indy-sdk? If they are something specific or very hard to fix maybe we can discuss about deprecating it before merging DIDComm V2 support. However it will be nice to make it work in order to ensure no breaking changes are introduced here (at least initially).
packages/core/src/modules/connections/__tests__/ConnectionService.test.ts
Outdated
Show resolved
Hide resolved
There is also a DCO issue, if you can fix it it will be great! |
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
@genaris Thanks for poinintg. I fixed broken tests. |
2df8146
into
openwallet-foundation:feat/didcomm-v2
No description provided.