-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update Github workflows #1500
Conversation
@TimoGlastra please see this as an attempt to fix the merge conflicts in #1428 |
Codecov Report
@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
- Coverage 85.79% 81.78% -4.02%
==========================================
Files 943 943
Lines 22588 22588
Branches 3685 3685
==========================================
- Hits 19380 18473 -907
- Misses 3200 4108 +908
+ Partials 8 7 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ryjones ! Could you fix the prettier errors?
|
||
ENV DEBIAN_FRONTEND noninteractive | ||
FROM ubuntu:22.04 as base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favour of using the newer ubuntu version. However, due to indy-sdk we need to rely on the downgraded libssl 1.1 packages. Do you guys think this could represent an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine for now. We should probably update this Dockerfile to use Askar instead of indy-sdk by default
Create cleanup-cache.yml Switch build to Yarn Update continuous-deployment.yml - Bump actions/checkout - Switch to `--immutable` with yarn (this is the new command) - Fix deprecated set-output command Add heap memory management Update continuous-integration.yml - Use a consistent runner - Fix set-output issues - Switch to setup-node Update lint-pr.yml Update repolinter.yml Update cleanup-cache.yml Update codeql-analysis.yml Create dependabot.yml Update dependabot.yml Update .dockerignore Update Dockerfile Remove accidental --immutable build: test large builders Add setup functions to CodeQL Update codeql-analysis.yml Delete local setup-node Update continuous-integration.yml Change to larger runners Signed-off-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Signed-off-by: Ry Jones <ry@linux.com>
done - @hyperledger/aries-framework-javascript-committers thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ryjones, this is great :)
|
||
ENV DEBIAN_FRONTEND noninteractive | ||
FROM ubuntu:22.04 as base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine for now. We should probably update this Dockerfile to use Askar instead of indy-sdk by default
Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Signed-off-by: Ry Jones <ry@linux.com> Signed-off-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Create cleanup-cache.yml
Switch build to Yarn
Update continuous-deployment.yml
--immutable
with yarn (this is the new command)Add heap memory management
Update continuous-integration.yml
Update lint-pr.yml
Update repolinter.yml
Update cleanup-cache.yml
Update codeql-analysis.yml
Create dependabot.yml
Update dependabot.yml
Update .dockerignore
Update Dockerfile
Remove accidental --immutable
build: test large builders
Add setup functions to CodeQL
Update codeql-analysis.yml
Delete local setup-node
Update continuous-integration.yml
Change to larger runners