Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update Github workflows #1500

Merged
merged 2 commits into from
Jul 21, 2023
Merged

build: Update Github workflows #1500

merged 2 commits into from
Jul 21, 2023

Conversation

ryjones
Copy link
Contributor

@ryjones ryjones commented Jul 6, 2023

Create cleanup-cache.yml

Switch build to Yarn

Update continuous-deployment.yml

  • Bump actions/checkout
  • Switch to --immutable with yarn (this is the new command)
  • Fix deprecated set-output command

Add heap memory management

Update continuous-integration.yml

  • Use a consistent runner
  • Fix set-output issues
  • Switch to setup-node

Update lint-pr.yml

Update repolinter.yml

Update cleanup-cache.yml

Update codeql-analysis.yml

Create dependabot.yml

Update dependabot.yml

Update .dockerignore

Update Dockerfile

Remove accidental --immutable

build: test large builders

Add setup functions to CodeQL

Update codeql-analysis.yml

Delete local setup-node

Update continuous-integration.yml

Change to larger runners

@ryjones ryjones requested a review from a team as a code owner July 6, 2023 15:43
@ryjones
Copy link
Contributor Author

ryjones commented Jul 6, 2023

@TimoGlastra please see this as an attempt to fix the merge conflicts in #1428

@ryjones ryjones marked this pull request as draft July 6, 2023 15:45
@codecov-commenter
Copy link

Codecov Report

Merging #1500 (db66068) into main (002be4f) will decrease coverage by 4.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
- Coverage   85.79%   81.78%   -4.02%     
==========================================
  Files         943      943              
  Lines       22588    22588              
  Branches     3685     3685              
==========================================
- Hits        19380    18473     -907     
- Misses       3200     4108     +908     
+ Partials        8        7       -1     

see 27 files with indirect coverage changes

Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryjones ! Could you fix the prettier errors?

.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved

ENV DEBIAN_FRONTEND noninteractive
FROM ubuntu:22.04 as base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of using the newer ubuntu version. However, due to indy-sdk we need to rely on the downgraded libssl 1.1 packages. Do you guys think this could represent an issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine for now. We should probably update this Dockerfile to use Askar instead of indy-sdk by default

Create cleanup-cache.yml

Switch build to Yarn

Update continuous-deployment.yml

- Bump actions/checkout
- Switch to `--immutable` with yarn (this is the new command)
- Fix deprecated set-output command

Add heap memory management

Update continuous-integration.yml

- Use a consistent runner
- Fix set-output issues
- Switch to setup-node

Update lint-pr.yml

Update repolinter.yml

Update cleanup-cache.yml

Update codeql-analysis.yml

Create dependabot.yml

Update dependabot.yml

Update .dockerignore

Update Dockerfile

Remove accidental --immutable

build: test large builders

Add setup functions to CodeQL

Update codeql-analysis.yml

Delete local setup-node

Update continuous-integration.yml

Change to larger runners

Signed-off-by: Ankur Banerjee <ankurdotb@users.noreply.github.com>
Signed-off-by: Ry Jones <ry@linux.com>
@ryjones
Copy link
Contributor Author

ryjones commented Jul 12, 2023

Thanks @ryjones ! Could you fix the prettier errors?

done - @hyperledger/aries-framework-javascript-committers thoughts?

@ryjones ryjones marked this pull request as ready for review July 13, 2023 00:11
@ryjones ryjones requested review from genaris and a team July 13, 2023 00:11
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryjones, this is great :)


ENV DEBIAN_FRONTEND noninteractive
FROM ubuntu:22.04 as base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine for now. We should probably update this Dockerfile to use Askar instead of indy-sdk by default

@TimoGlastra TimoGlastra enabled auto-merge (squash) July 21, 2023 12:49
@TimoGlastra TimoGlastra mentioned this pull request Jul 21, 2023
6 tasks
@TimoGlastra TimoGlastra merged commit 13f074b into main Jul 21, 2023
7 checks passed
@TimoGlastra TimoGlastra deleted the fix-build branch July 21, 2023 13:08
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Jul 26, 2023
Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com>
Signed-off-by: Ry Jones <ry@linux.com>
Signed-off-by: Ankur Banerjee <ankurdotb@users.noreply.github.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants