Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anoncreds): auto create link secret #1521

Merged

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Jul 22, 2023

As discussed in July 6th WG call, here we add an optional configuration parameter for anoncreds-rs and indy-sdk modules that makes holder services to auto create a default link secret if no one has been created yet. This check is performed only when it is actually needed (i.e. when creating a credential request) rather than at agent initialization.

It defaults to true, meaning that normally it will not be needed to the consumer to do any specific logic to use AnonCreds as a holder.

Superseeds #1491 and fixes #1490

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
…n by default

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner July 22, 2023 17:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Merging #1521 (98b8913) into main (08cdf1b) will increase coverage by 23.61%.
The diff coverage is 56.41%.

@@             Coverage Diff             @@
##             main    #1521       +/-   ##
===========================================
+ Coverage   62.14%   85.76%   +23.61%     
===========================================
  Files         773      945      +172     
  Lines       17955    22637     +4682     
  Branches     3046     3924      +878     
===========================================
+ Hits        11159    19414     +8255     
+ Misses       6261     3040     -3221     
+ Partials      535      183      -352     
Impacted Files Coverage Δ
...ckages/anoncreds-rs/src/AnonCredsRsModuleConfig.ts 14.28% <0.00%> (ø)
packages/anoncreds/tests/legacyAnonCredsSetup.ts 75.75% <ø> (ø)
packages/indy-sdk/src/IndySdkModuleConfig.ts 77.77% <0.00%> (ø)
tests/e2e-test.ts 100.00% <ø> (ø)
...sdk/src/anoncreds/services/IndySdkHolderService.ts 8.02% <14.28%> (ø)
...ncreds-rs/src/services/AnonCredsRsHolderService.ts 87.64% <28.57%> (+1.58%) ⬆️
packages/anoncreds/src/utils/linkSecret.ts 85.71% <85.71%> (ø)
packages/anoncreds/src/AnonCredsApi.ts 71.27% <100.00%> (+53.97%) ⬆️
packages/anoncreds/src/index.ts 100.00% <100.00%> (ø)
packages/anoncreds/src/utils/index.ts 100.00% <100.00%> (ø)

... and 464 files with indirect coverage changes

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :)

@TimoGlastra TimoGlastra merged commit c6f03e4 into openwallet-foundation:main Jul 25, 2023
7 checks passed
@genaris genaris deleted the feat/auto-create-link-secret branch July 25, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link secret to agent initalization
3 participants