STOR-2586: Rebase to v2.0.0 for OCP 4.21 #179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing Slowset Utility
…sion-if-not-required Disable node expansion if not required
`defer ctx.Done()` does not actually cancel the context.
So it will be clear which VAC the status is describing. Specifically, we now set target for Pending status to indicate which VAC we are waiting for.
use t.Context() in test
always overwrite TargetVolumeAttributesClassName when setting Status
…ction lease on sigterm
…-faster Restart external-resizer faster by releasing leader election lease on sigterm
There's no logic to requeue over PV creation, which means that if we return over a PV not being found, the resize could take up to resyncPeriod. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Requeue PVC over PV creation
Fix version of kubernetes for alpha version of ReleaseLeaderElectionOnExit fg
5f38a907 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f6242 Update go to 1.24.6 74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7 Update CSI prow driver version to v1.17.0 0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af10153 update to go 1.24.4 f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db Remove chrishenzie from kubernetes-csi-reviewers git-subtree-dir: release-tools git-subtree-split: 5f38a907597230563f5e2213aea116acdd9d86bc
Update kubernetes dependencies to v1.34.0
Promote VolumeAttributesClass to GA
Also fix the test. Previous test does not actually cover the relevant code path.
extraModifyMetadata should not modify VAC in informer
fix wrong error is used when checking final error. map is not safe for concurrent read/write from multiple worker. Also fixed that. Added related tests.
We should keep retry the previously specified target.
Support rollback to VAC A if modifying from A to B failed with a final error. This works just like we modifying it again to C on final error. The significant changes in the sync logic: - Always retry if pvc.Status.ModifyVolumeStatus is not nil, which means the last transation does not finish successfully. - Keep reconciling to the previous target if spec is rolled back to nil, until it succeeds or we get an infeasible error. Then we just leave it at its current state and stop reconciling for it, since user may not care about it now.
Make it harder to abuse VAC quota by change spec to an non-existing VAC when the volume is partially modified. Basically reverting 6c8c10f.
modify: support rollback
to determine the default value of VAC feature gate
probe VAC API availability
…e-version Remove hardcoded e2e version
74502e54 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 53344305 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146 Bump actions/checkout from 4 to 5 5ec1a52b use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages git-subtree-dir: release-tools git-subtree-split: 74502e544bc6a17820892c0d490e8f0b59462998
…ools-update Release tools update
Bump CSI spec version
Allow tests to run
Rbac change for VolumeAttributesClass
Add CHANGELOG-2.0.md
TargetVolumeAttributesClassName is no longer valid for Pending status because the change is reverted in d03a1e7
remove TargetVolumeAttributesClassName change from CHANGELOG
And remove .github
jsafrane
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jsafrane: This pull request references STOR-2586 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
cc @openshift/storage |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jsafrane: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changelogs
https://github.com/kubernetes-csi/external-resizer/blob/release-2.0/CHANGELOG/CHANGELOG-2.0.md
Summary of changes
Major features and breaking changes between v1.14.0 and v2.0.0:
Carried commits
From commits.tsv analysis:
7065706 -
UPSTREAM: <carry>: Add OpenShift files- cherry-pick (with squashed updates)abc33ad -
UPSTREAM: 521: Requeue PVC over PV creation- dropf893c39 -
UPSTREAM: <carry>: Updating ose-csi-external-resizer-container image to be consistent with ART for 4.21- squashDiff to upstream: kubernetes-csi/external-resizer@v2.0.0...jsafrane:external-resizer:rebase-v2.0.0
Previous rebase: #171