-
Couldn't load subscription status.
- Fork 148
Removing Slowset Utility #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @mdzraf. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
|
csi-lib-utils new version was released, waiting on dependency bump in resizer to put out new rev. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, mdzraf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
I am in middle of making 1.14 release. Lets finish that and then we can merge this. |
|
Hey @gnufied, anything else we are waiting on to merge? |
|
I was waiting for cutting a release, so as I didn't want to merge. |
|
Yes, I saw that you released 1.14 last week, I was just checking in to make sure there was nothing else needed from my end, thank you! |
|
/hold cancel |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR removes the slowset utility out of the external-resizer into csi-lib-utils so that other sidecars can also use this utility.
Special notes for your reviewer:
This PR must not be merged until this csi-lib-utils PR is merged. Currently in this code, it is pointing to a local version of csi-lib-utils that was being used for testing, this will change to point to the actual csi-lib-utils once the slowset is merged into csi-lib-utils.Does this PR introduce a user-facing change?: