Add CHANGELOG-2.0.md #535
Add CHANGELOG-2.0.md #535
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunnylovestiramisu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
| [Documentation](https://kubernetes-csi.github.io) | ||
|
|
||
| # Changelog since 1.14.0 | ||
|
|
There was a problem hiding this comment.
Do we need to add any urgent upgrade notes? Are there any breaking changes?
There was a problem hiding this comment.
Is emulated version change considered an urgent upgrade notes? What qualifies as urgent?
There was a problem hiding this comment.
We should explain why we bumped the major version. Soemthing like:
The minimum Kubernetes version is 1.34 for the storage/v1 VolumeAttributesClass API object. Emulated versions below 1.34 are supported but a restart is required once the emulated version is updated to 1.35.
There was a problem hiding this comment.
Similar note should go in the provisioner.
There was a problem hiding this comment.
Also we have updated RBAC rules that require VAC right?
There was a problem hiding this comment.
What do we need to update?
It is already
# only required if enabling the alpha volume modify feature
- apiGroups: ["storage.k8s.io"]
resources: ["volumeattributesclasses"]
verbs: ["get", "list", "watch"]
There was a problem hiding this comment.
It's now required instead of optional right?
k8s-ci-robot
added
release-note
sunnylovestiramisu
force-pushed
the
v1.34
branch
from
79ddacf to
e0b3ef5
Compare
| ### Uncategorized | ||
|
|
||
| - Annotate PVCs that don't require node expansion, so as kubelet can skip them ([#496](https://github.com/kubernetes-csi/external-resizer/pull/496), [@gnufied](https://github.com/gnufied)) | ||
| - Update CSI spec to v1.12.0 which moves volume modification feature to stable ([#534](https://github.com/kubernetes-csi/external-resizer/pull/534), [@gnufied](https://github.com/gnufied)) |
There was a problem hiding this comment.
I don't recall we left things in Uncategorized, we always rolled them into bugs, feature or cleanup sections. I think these can be similarly rolled into one of those.
|
|
||
| ### (No, really, you MUST read this before you upgrade) | ||
|
|
||
| - The minimum Kubernetes version is 1.34 for the storage/v1 VolumeAttributesClass API object. Emulated versions below 1.34 are supported but a restart is required once the emulated version is updated to 1.35. |
There was a problem hiding this comment.
Should it contain user facing content rather?
"This version of resizer requires v1.34.0 of Kubernetes to support Volume modification via VolumeAttributeClass APIs".
Emulated versions below 1.34 are supported but a restart is required once the emulated version is updated to 1.35.
Emulated versions below v1.34 are supported but volume modification feature will be disabled in that case right? Should we explicitly say that?
5 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: