Uses published daily snapshot dependencies #141

dbbaughe · 2021-09-09T21:23:25Z

Signed-off-by: Drew Baugher 46505179+dbbaughe@users.noreply.github.com

CheckList:

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dbbaughe · 2021-09-09T22:12:35Z

That is interesting.... link checker fails because of link at bottom of rfc
https://github.com/opensearch-project/index-management/blob/main/docs/rfc.md

But why didn't it fail for previous PRs...

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

saratvemulapalli · 2021-09-10T16:55:44Z

build.gradle

@@ -182,7 +182,7 @@ dependencies {
 }

 repositories {
-    mavenLocal()


As part of the CI/CD we are trying to run integration/bwc tests which qualifies the bundle and allows the maven artifacts to be published.
It would rely on mavenlocal() to run these tests.

Ah I see, I'll add it back w/ a comment explaining what it's for as it didn't seem needed in our repo.

Did you need mavenLocal in the buildscript repositories too?

Yeah still trying to figure out if there is any other way. But seems like mavenlocal() could be a simpler solution at this point.
The CI pipelines are in development we are learning through the process, so we didn't know either.

Could you point me to the buildscript ?

https://github.com/opensearch-project/index-management/blob/main/build.gradle#L43-L47

I removed it from here too.

When you do your CI builds are you building release or snapshot? Because if you're also trying to build SNAPSHOT and I add this mavenLocal back.. then I have to add it to the top of the repositories so that it makes sure to check there first to find it (otherwise it'll find it first in our SNAPSHOT repository). But, if we do make mavenLocal first... now all devs/contributors need to make sure they clean out their local maven repositories of OpenSearch related artifacts if they want to make sure they are actually getting it from the SNAPSHOT repo which is a bit annoying.

Yeah buildscript fetches the build-tools i.e opensearchplugin and it would depend on mavenlocal() too.
That is a great point. I think it would be SNAPSHOT repository but i'll get back on this.

I really think you should back this out of 1.1 and make the change in 1.2. Branch for 1.1. We didn't give our maven publishing any bake time and the bundle build doesn't need more issues right now.

@dblock This commit was not included in our 1.1 branch, and is not in our 1.x branch yet either. It's only in main.

dblock · 2021-09-28T20:53:02Z

build.gradle

@@ -41,9 +41,9 @@ buildscript {
    }

    repositories {
-        mavenLocal()


We need to preserve mavenLocal here for bundle build.

…pensearch-project#141) Combine API and other code fix

* Add integTest script to the repo (#94) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Removing Usages of Action Get Call and using listeners (#100) Signed-off-by: Aditya Jindal <aditjind@amazon.com> * Enhance ISM template (#105) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Explain response still use old opendistro policy id (#109) * Explain response still use old opendistro policy id * Use hardcoded policyid setting in tests for explain response * Trying to fix flaky tests * Storing user information as part of the job when security plugin is installed (#113) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * ISM/Notification channel support (#117) * Updates NAME of transport actions * Upgrades Kotlin version, updates dependencies on other OS plugins, adds notification plugin as a test resource and includes it in test clusters * Adds support for Channels in error notifications and notification actions * Adds support for sending notifications to channels * Adds support for publishing notifications to the legacy destinations through the Notification plugin and some cleanup * Removes notification alerting jar dependency * Adds compile only dep on commons codec for digest utils sha1 method in ism rollup * Updates Error Notification to make channel/destination nullable, and adds helper methods for publish calls * Constructs URL for legacy custom webhook Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes Feature enum and dep Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Trying something else Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Addresses comments Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Storing user object in all APIs and enabling filter of response based on user (#115) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * Upgrade dependencies to 1.1 and build snapshot by default. (#121) Signed-off-by: dblock <dblock@amazon.com> * Security improvements (#126) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * Removes support for notification plugin (#136) Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updating security filtering logic (#137) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * Release note for 1.1.0.0 release. (#139) * Release note for 1.1.0.0 release. Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Correct copyright notices * Uses published daily snapshot dependencies (#141) Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * License header check (#142) * Provide default copyright header using IDE feature Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Address #103 history write index is rolled over even if the history indices are disabled * Removed integtest.sh. (#148) Signed-off-by: dblock <dblock@dblock.org> * Adds mavenLocal back to repositories (#158) Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Making snapshot name to scripted input in template (#77) Signed-off-by: Ravi Thaluru <ravi1092@gmail.com> * Fix issues with security changes in rollup runnner (#161) * Updates index management version to 1.2 (#157) * Updates index management version to 1.2 * Updates job scheduler snapshot to 1.2 in test resources Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds setting to search all rollup jobs on a target index (#165) * Adds cluster setting to search all rollup jobs Signed-off-by: Clay Downs <downsrob@amazon.com> * Adds implementation for the delay feature in rollup jobs (#147) * Adds delay implementation for rollup jobs * Removes non-continuous delay implementation * Adds additional rollup delay tests Signed-off-by: Clay Downs <downsrob@amazon.com> * Updates testCompile mockito version, adds AwaitsFix annotation to MetadataRegressionIT tests (#168) * Updates testCompile mockito version to match OpenSearch changes * AwaitsFix on the failing MetadataRegressionIT tests Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds cluster setting to configure index state management jitter (#153) * Adds jitter cluster setting, sets jitter to 0 for ISM tests Signed-off-by: Clay Downs <downsrob@amazon.com> * Allows out of band rollovers on an index without causing ISM to fail (#180) * Allows out of band rollovers on an index without causing ISM to fail Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes detekt issue Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Remove policy API on read only indices (#182) * In explain API not showing the total count to all users (#185) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Aditya Jindal <13850971+aditjind@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com> Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

Uses published daily snapshot dependencies

4475f3b

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

dbbaughe force-pushed the main branch from 44b2d58 to 4475f3b Compare September 9, 2021 22:13

dbbaughe requested a review from bowenlan-amzn September 9, 2021 22:37

bowenlan-amzn approved these changes Sep 9, 2021

View reviewed changes

dbbaughe merged commit 1247284 into opensearch-project:main Sep 9, 2021

dbbaughe mentioned this pull request Sep 9, 2021

Use AWS OSS Maven -SNAPSHOT for plugin dependencies opensearch-project/opensearch-plugins#45

Closed

14 tasks

bowenlan-amzn added maintenance improves code quality, but not the product v1.1.0.0 labels Sep 10, 2021

saratvemulapalli reviewed Sep 10, 2021

View reviewed changes

abbashus mentioned this pull request Sep 28, 2021

Build from public Maven instead of mavenLocal #155

Closed

dblock reviewed Sep 28, 2021

View reviewed changes

build.gradle

@@ -41,9 +41,9 @@ buildscript {

}

repositories {

mavenLocal()

Copy link

Member

dblock Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to preserve mavenLocal here for bundle build.

thalurur pushed a commit to thalurur/open-index-management that referenced this pull request Oct 22, 2021

Combine getRollup with getExplain API in backend and other code fix (o…

1bb198a

…pensearch-project#141) Combine API and other code fix

wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023

Uses published daily snapshot dependencies (opensearch-project#141)

478c258

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uses published daily snapshot dependencies #141

Uses published daily snapshot dependencies #141

dbbaughe commented Sep 9, 2021

dbbaughe commented Sep 9, 2021

saratvemulapalli Sep 10, 2021

dbbaughe Sep 10, 2021

dbbaughe Sep 10, 2021

saratvemulapalli Sep 10, 2021

dbbaughe Sep 10, 2021

saratvemulapalli Sep 10, 2021

dblock Sep 11, 2021

dbbaughe Sep 12, 2021

dblock Sep 28, 2021

Uses published daily snapshot dependencies #141

Uses published daily snapshot dependencies #141

Conversation

dbbaughe commented Sep 9, 2021

dbbaughe commented Sep 9, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment