Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data layer source name #588

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

junqiu-lei
Copy link
Member

Description

Update layer source name from Data source to Index pattern followed from #584 (comment)

Issues Resolved

#584

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei
Copy link
Member Author

junqiu-lei commented Feb 23, 2024

Unrelated test failure due to OSD issue opensearch-project/OpenSearch-Dashboards#5561 (comment), adding --single-version=loose to resolve dependencies conflict.

@junqiu-lei junqiu-lei added the documentation Improvements or additions to documentation label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.36%. Comparing base (811e8b0) to head (1b41da4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   41.36%   41.36%           
=======================================
  Files          53       53           
  Lines        1789     1789           
  Branches      328      328           
=======================================
  Hits          740      740           
  Misses       1019     1019           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei
Copy link
Member Author

One cypress test failed on CI but passed at my local, cut issue separately #592

  Documents layer

We detected that the Electron Renderer process just crashed.

We have failed the current spec but will continue running the next spec.

This can happen for a number of different reasons.

If you're running lots of tests on a memory intense application.
  - Try increasing the CPU/memory on the machine you're running on.
  - Try enabling experimentalMemoryManagement in your config file.
  - Try lowering numTestsKeptInMemory in your config file during 'cypress open'.

You can learn more here:

https://on.cypress.io/renderer-process-crashed

  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        2                                                                                │
  │ Passing:      0                                                                                │
  │ Failing:      1                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      1                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     1 minute, 18 seconds                                                             │
  │ Spec Ran:     documentsLayer.cy.js                                                             │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

Copy link
Member

@ryanbogan ryanbogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VijayanB
Copy link
Member

@junqiu-lei Do we need change in documentation website too? i remember sharing screenshot with select data source.

@junqiu-lei
Copy link
Member Author

@junqiu-lei Do we need change in documentation website too? i remember sharing screenshot with select data source.

Sure, will raise PR to document repo if change needed.

@junqiu-lei junqiu-lei merged commit 0647a71 into opensearch-project:main Feb 26, 2024
9 of 11 checks passed
@junqiu-lei junqiu-lei deleted the update_source_name branch February 26, 2024 19:52
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 26, 2024
* Update data layer source name

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 0647a71)
junqiu-lei added a commit that referenced this pull request Feb 26, 2024
* Update data layer source name

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 0647a71)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x documentation Improvements or additions to documentation v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants