Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support Multiple Data Source in Maps Dashboards Plugin #584

Closed
Tracked by #5870
BionIT opened this issue Feb 14, 2024 · 7 comments
Closed
Tracked by #5870

[FEATURE] Support Multiple Data Source in Maps Dashboards Plugin #584

BionIT opened this issue Feb 14, 2024 · 7 comments
Labels
enhancement New feature or request v2.13.0 v2.14.0

Comments

@BionIT
Copy link

BionIT commented Feb 14, 2024

Is your feature request related to a problem?

With multiple data source enabled, users of OpenSearch Dashboards are able to create data source connections and query local and remote OpenSearch clusters. Enabling multiple data source at dashboards plugin would ensure users that have been using the multiple data source feature to have a consistent experience in the dashboard, and allows users to use the same dashboard for different clusters.

What solution would you like?

Support multiple data source in the maps dashboards plugin

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@BionIT
Copy link
Author

BionIT commented Feb 19, 2024

Thanks @kgcreative @junqiu-lei for the sync up! A quick summary from the offline meeting: Maps plugin uses index pattern which already supports multiple data source. During the walk through, we did find a few things we need to address before close out:

  1. Change the label from Data source to Index pattern at the location below - @junqiu-lei
    Screenshot 2024-02-19 at 3 37 51 PM
  2. Fix the combo box which shows 2 options selected - @junqiu-lei @BionIT
  3. Add data source connection name as prefix to the selector - @BionIT will look into this and evaluate if we can use the component in discover page

@junqiu-lei
Copy link
Member

Thanks @BionIT for the clear summary!

@BionIT
Copy link
Author

BionIT commented Feb 20, 2024

For 3, I have created an issue in dashboards repo opensearch-project/OpenSearch-Dashboards#5900

@BionIT
Copy link
Author

BionIT commented Feb 28, 2024

Thanks @junqiu-lei for merging the label change! Now we have 1-3 closed.
@kgcreative should we do a quick demo for the maps plugin before closing this out?

@kgcreative
Copy link
Member

@junqiu-lei can you either post before/after screenshots, or a screen recording here? I think we can review and close out async

@junqiu-lei
Copy link
Member

junqiu-lei commented Feb 28, 2024

@kgcreative @BionIT Hi, I made a screen recording for the maps multi data source support, please review, thanks!

Screen.Recording.2024-02-28.at.2.50.27.PM.mov

@kgcreative
Copy link
Member

LGTM! Ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.13.0 v2.14.0
Projects
None yet
Development

No branches or pull requests

4 participants