Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi data source display in Maps app #611

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

junqiu-lei
Copy link
Member

Description

Support multi data source display in Maps app. In maps list page, it will display all available data source. In maps visualization page, it will display all data sources in using.

Demo

Screen.Recording.2024-04-17.at.1.57.21.PM.mov

Test

Will add test in another PR in https://github.com/opensearch-project/opensearch-dashboards-functional-test which can mock remote data source.

Issues Resolved

Part of #584

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
public/components/map_container/map_container.tsx Outdated Show resolved Hide resolved
public/components/map_page/map_page.tsx Outdated Show resolved Hide resolved
public/components/map_page/map_page.tsx Show resolved Hide resolved
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei
Copy link
Member Author

The cypress CI failure is known issue unrelated to this PR.

@junqiu-lei junqiu-lei merged commit f325212 into opensearch-project:main Apr 19, 2024
7 of 9 checks passed
@junqiu-lei junqiu-lei deleted the neo-maps-app branch April 19, 2024 20:35
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-611-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f325212eb75c491b1b9e715403732d810197c869
# Push it to GitHub
git push --set-upstream origin backport/backport-611-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-611-to-2.x.

junqiu-lei added a commit to junqiu-lei/dashboards-maps that referenced this pull request Apr 22, 2024
* Support multi data source display in Maps app

Signed-off-by: Junqiu Lei <junqiu@amazon.com>

(cherry picked from commit f325212)
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei added a commit that referenced this pull request Apr 22, 2024
* Support multi data source display in Maps app



(cherry picked from commit f325212)

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants