Align all flyout components to be overlay kind and add close button X in header #373

djindjic · 2022-11-30T19:05:34Z

Description

Refactored all Flyout's to be as type="overlay" (default type value)

Issues Resolved

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

public/pages/Dashboard/components/FindingsDashboard/FindingFlyout.js

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

codecov-commenter · 2022-12-01T16:44:07Z

Codecov Report

Merging #373 (983f7d2) into main (6287bd5) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   52.68%   52.57%   -0.11%     
==========================================
  Files         207      207              
  Lines        5444     5459      +15     
  Branches      764      766       +2     
==========================================
+ Hits         2868     2870       +2     
- Misses       2574     2587      +13     
  Partials        2        2

Impacted Files	Coverage Δ
...oard/components/FindingsDashboard/FindingFlyout.js	`33.33% <0.00%> (-2.39%)`	⬇️
...er/containers/ConfigureActions/ConfigureActions.js	`6.72% <0.00%> (-0.69%)`	⬇️
...erting-dashboards-plugin/public/utils/constants.js	`100.00% <0.00%> (ø)`
...gin/public/pages/Dashboard/containers/Dashboard.js	`56.02% <0.00%> (ø)`
...ic/pages/CreateTrigger/components/Action/Action.js	`48.00% <0.00%> (ø)`
.../pages/MonitorDetails/containers/MonitorDetails.js	`0.00% <0.00%> (ø)`
...eMonitor/containers/CreateMonitor/CreateMonitor.js	`59.83% <0.00%> (ø)`
...oard/components/FindingsDashboard/findingsUtils.js	`56.92% <0.00%> (ø)`
...s/AcknowledgeAlertsModal/AcknowledgeAlertsModal.js	`1.83% <0.00%> (ø)`
...ateMonitor/components/VisualGraph/utils/helpers.js	`96.80% <0.00%> (+0.03%)`	⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

public/components/Flyout/flyouts/__snapshots__/flyouts.test.js.snap

public/components/Flyout/flyouts/alertsDashboard.js

public/pages/Dashboard/components/FindingsDashboard/FindingFlyout.js

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

public/pages/Dashboard/components/FindingsDashboard/FindingFlyout.js

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

… in header (#373) * align all flyout components to overlay Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify if statement Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add close button to flyout header, remove footer Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify flex layout Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * update snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add data-test-subject on flyout header title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix cypress tests, overflow on flyout title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * eui-textTruncate on flyout titles Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> (cherry picked from commit bcfe119)

… in header (#373) (#399) * align all flyout components to overlay Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify if statement Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add close button to flyout header, remove footer Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify flex layout Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * update snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add data-test-subject on flyout header title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix cypress tests, overflow on flyout title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * eui-textTruncate on flyout titles Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> (cherry picked from commit bcfe119) Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>

… in header (#373) * align all flyout components to overlay Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify if statement Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add close button to flyout header, remove footer Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify flex layout Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * update snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add data-test-subject on flyout header title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix cypress tests, overflow on flyout title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * eui-textTruncate on flyout titles Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> (cherry picked from commit bcfe119)

… in header (#373) (#427) * align all flyout components to overlay Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify if statement Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add close button to flyout header, remove footer Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify flex layout Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * update snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add data-test-subject on flyout header title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix cypress tests, overflow on flyout title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * eui-textTruncate on flyout titles Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> (cherry picked from commit bcfe119) Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>

* Bumped version from 2.3 to 2.4. (#346) * Bumping version from 2.3 to 2.4. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted OSD version used by unit test workflow to last version that allowed the tests to pass. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped d3-color version. (#350) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Support windows CI (#354) * Support windows CI Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add 2.4 release notes (#357) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Fix confidence bug (#360) This PR fixed a bug when showing confidence in trigger definition. Confidence is usually a non-decreasing function on an interval. But we incorrectly only show confidence when the corresponding anomaly grade is larger than 0. Testing done: 1. manually tested that the bug is fixed. See attached snapshots. 2. yarn test:jest Signed-off-by: Kaituo Li <kaituo@amazon.com> * Bumped loader-utils version to address dependabot alert. (#361) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * updated link to dashboards developer guide (#349) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Fixed a bug that prevented the throttling settings from displaying for PER_ALERT bucket level trigger actions. (#328) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjust OpenSearch-Dashboards version used by test workflows. (#363) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * avoid nesting search inside search (#382) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Bumped loader-utils version to address dependabot alert. (#379) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * [BUG] Issues in the UI above 200 destinations paging issue #195 (#375) * [BUG] Issues in the UI above 200 destinations #195 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Issues in the UI above 200 destinations #195 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Issues in the UI above 200 destinations #195 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * sorted data by date (#385) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Align all flyout components to be overlay kind and add close button X in header (#373) * align all flyout components to overlay Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify if statement Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add close button to flyout header, remove footer Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * simplify flex layout Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * update snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * add data-test-subject on flyout header title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix cypress tests, overflow on flyout title Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * eui-textTruncate on flyout titles Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * Bumped decode-uri-component version to address CVE-2022-38900. (#400) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed an issue that was causing the results of the ctx object to be empty. (#334) * Fixed an issue that was causing the results of the ctx object to be empty. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed an issue that was causing the results of the ctx object to be empty. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Consolidated duplicate code. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Keep monitor table cell width flexible; Check for whether monitor is enabled when displaying related action (#402) * made table cells flexible; added monitor enabled check for actions Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * minor updates Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated jest snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Add release notes for 2.4.1 (#420) Signed-off-by: Saurabh Singh <sisurab@amazon.com> Signed-off-by: Saurabh Singh <sisurab@amazon.com> * Bumped version to 2.5. (#437) * Bumped version to 2.5. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted test workflows to not use 2.5 tag for OSD as it hasn't been created yet. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * 2.5.0 release notes. (#440) * Drafted 2.5 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.5 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the help text elements displayed when users access the destinations list page after destinations deprecation. (#413) (#438) (#443) * Refactored the help text elements displayed when users access the destinations list page after destinations deprecation. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the help text elements displayed when users access the destinations list page after destinations deprecation. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshot. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated button text. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshot files. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored landing page logic. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 58dee83) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> * Fix CVE-2022-46175 (#453) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Updated MAINTAINERS.md to match recommended opensearch-project format. (#435) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> * Refactored cypress and unit test workflows to use the 2.5.0 tag as the OSD repo reference. (#462) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Kaituo Li <kaituo@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Saurabh Singh <sisurab@amazon.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: dblock <dblock@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Kaituo Li <kaituo@amazon.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>

djindjic requested a review from a team November 30, 2022 19:05

align all flyout components to overlay

5b25146

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

djindjic force-pushed the feature/refactor-flyouts-to-overlay branch from 559d4dd to 5b25146 Compare November 30, 2022 19:11

amsiglan reviewed Nov 30, 2022

View reviewed changes

public/pages/Dashboard/components/FindingsDashboard/FindingFlyout.js Outdated Show resolved Hide resolved

djindjic added 2 commits November 30, 2022 22:37

simplify if statement

fc6b881

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

fix snapshot

ad532bc

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

djindjic force-pushed the feature/refactor-flyouts-to-overlay branch from 88321f2 to ad532bc Compare December 1, 2022 16:02

add close button to flyout header, remove footer

0feaf38

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

djindjic changed the title ~~Align all flyout components to be overlay kind~~ Align all flyout components to be overlay kind and add close button X in header Dec 1, 2022

amsiglan reviewed Dec 1, 2022

View reviewed changes

public/components/Flyout/flyouts/__snapshots__/flyouts.test.js.snap Outdated Show resolved Hide resolved

amsiglan reviewed Dec 1, 2022

View reviewed changes

public/components/Flyout/flyouts/alertsDashboard.js Outdated Show resolved Hide resolved

amsiglan reviewed Dec 1, 2022

View reviewed changes

public/pages/Dashboard/components/FindingsDashboard/FindingFlyout.js Outdated Show resolved Hide resolved

djindjic added 4 commits December 2, 2022 08:35

simplify flex layout

e4c7dc2

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

update snapshot

f513a59

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

add data-test-subject on flyout header title

b87a874

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

fix cypress tests, overflow on flyout title

de66fc4

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

djindjic force-pushed the feature/refactor-flyouts-to-overlay branch from 400a2f1 to de66fc4 Compare December 2, 2022 15:43

amsiglan reviewed Dec 2, 2022

View reviewed changes

public/pages/Dashboard/components/FindingsDashboard/FindingFlyout.js Outdated Show resolved Hide resolved

djindjic added 2 commits December 2, 2022 22:20

fix snapshot

c913383

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

eui-textTruncate on flyout titles

983f7d2

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

AWSHurneyt added the backport 2.x label Dec 5, 2022

amsiglan approved these changes Dec 6, 2022

View reviewed changes

AWSHurneyt approved these changes Dec 6, 2022

View reviewed changes

AWSHurneyt merged commit bcfe119 into opensearch-project:main Dec 6, 2022

opensearch-trigger-bot bot mentioned this pull request Dec 6, 2022

[Backport 2.x] Align all flyout components to be overlay kind and add close button X in header #399

Merged

lezzago added the backport 2.3 label Dec 21, 2022

opensearch-trigger-bot bot mentioned this pull request Dec 21, 2022

[Backport 2.3] Align all flyout components to be overlay kind and add close button X in header #427

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align all flyout components to be overlay kind and add close button X in header #373

Align all flyout components to be overlay kind and add close button X in header #373

djindjic commented Nov 30, 2022 •

edited

Loading

codecov-commenter commented Dec 1, 2022 •

edited

Loading

Align all flyout components to be overlay kind and add close button X in header #373

Align all flyout components to be overlay kind and add close button X in header #373

Conversation

djindjic commented Nov 30, 2022 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Dec 1, 2022 • edited Loading

Codecov Report

djindjic commented Nov 30, 2022 •

edited

Loading

codecov-commenter commented Dec 1, 2022 •

edited

Loading