Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The "X" (close) icon is missing from the monitor details flyout #300

Closed
xeniatup opened this issue Aug 4, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@xeniatup
Copy link

xeniatup commented Aug 4, 2022

What is the bug?
The "X" (close) icon is missing from the monitor details flyout's top right corner, which creates inconsistency in the flyout behavior and disrupts the flow for user.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to Alerting
  2. Land on Alerts by trigger table (assuming that the table is populated)
  3. Click on any entry in the table
  4. See the flyout with monitor details open
  5. See the missing "X" button in the flyout header

What is the expected behavior?
The "X" icon should be present in the flyout header to allow user to close the flyout using the regular pattern.

What is your host/environment?

  • OS: macOS
  • Version 12.4
  • Plugins Alerting
  • Browser Chrome, Firefox, Safari

Do you have any screenshots?
Screen Shot 2022-08-04 at 12 37 50 AM

@xeniatup xeniatup added bug Something isn't working untriaged labels Aug 4, 2022
@AWSHurneyt
Copy link
Collaborator

Added these buttons to the Alerts and Findings flyouts locally, and will be publishing a PR once the tests finish.

@amsiglan
Copy link
Collaborator

@AWSHurneyt Let's create the PR for this

@amsiglan
Copy link
Collaborator

amsiglan commented Dec 6, 2022

Completed

@amsiglan amsiglan closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants