Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The header of Alerting monitor details flyout is not aligned with the page tabs height #298

Closed
xeniatup opened this issue Aug 4, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@xeniatup
Copy link

xeniatup commented Aug 4, 2022

What is the bug?
The header of the monitor details flyout has the same type of underline as the tabs on the page. The two lines almost meet at the edge of the flyout, but the difference in the positions of the lines is too small to look intentional, which brings an appearance of a bug.

How can one reproduce the bug?
Steps to reproduce the behavior:

  • Go to Alerting
  • Click on any entry in the Alerts by trigger table (assuming that the table is populated)
  • See the flyout with monitor details

What is the expected behavior?
The lines under the page tabs and the flyout title should either be on the same level or farer apart for the page to look organized in a more structured way.

What is your host/environment?

  • OS: macOS
  • Version 12.4
  • Plugins Alerting
  • Browser Chrome, Firefox, Safari

Do you have any screenshots?

Screen Shot 2022-08-04 at 12 13 51 AM

@xeniatup xeniatup added bug Something isn't working untriaged labels Aug 4, 2022
@AWSHurneyt
Copy link
Collaborator

Good catch. If the lines can't be the same, I'll make the flyout header a little bigger so the difference looks more intentional.

@amsiglan
Copy link
Collaborator

amsiglan commented Dec 6, 2022

No longer relevant as we moved to using overlay type of flyouts.

@amsiglan amsiglan closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants