[Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. #7118

harishbhakuni · 2023-04-12T02:15:13Z

Description

Changes in Create Snapshot API Required for #6575.

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-04-12T02:19:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13916/
CommitID: 3d5402b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java

server/src/main/java/org/opensearch/cluster/SnapshotsInProgress.java

.../java/org/opensearch/index/snapshots/blobstore/BlobStoreRemStoreBasedIndexShardSnapshot.java

server/src/main/java/org/opensearch/index/shard/IndexShard.java

.../java/org/opensearch/index/snapshots/blobstore/BlobStoreRemStoreBasedIndexShardSnapshot.java

server/src/main/java/org/opensearch/repositories/Repository.java

server/src/main/java/org/opensearch/repositories/ShardGenerations.java

github-actions · 2023-06-07T14:59:36Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/17036/
CommitID: f2eff60

github-actions · 2023-06-07T15:07:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

URL: https://build.ci.opensearch.org/job/gradle-check/17037/
CommitID: 7f84c24
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

server/src/main/java/org/opensearch/snapshots/SnapshotShardsService.java

server/src/main/java/org/opensearch/snapshots/SnapshotsService.java

…re interoperability. Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

github-actions · 2023-06-07T22:07:42Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu

URL: https://build.ci.opensearch.org/job/gradle-check/17080/
CommitID: c3ef955
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

server/src/main/java/org/opensearch/cluster/SnapshotsInProgress.java

…re interoperability. (opensearch-project#7118) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

… for remote store interoperability. (opensearch-project#7118) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

…re interoperability. (opensearch-project#7118) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

harishbhakuni changed the title ~~Create snap flow~~ [Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. Apr 12, 2023

harishbhakuni marked this pull request as ready for review April 12, 2023 02:17

harishbhakuni requested review from Bukhtawar, CEHENKLE, Rishikesh1159, VachaShah, anasalkouz, andrross, dblock, dreamer-89, gbbafna, kartg, kotwanikunal, mch2, nknize, owaiskazi19, reta, ryanbogan, saratvemulapalli, setiah, shwetathareja, tlfeng and xuezhou25 as code owners April 12, 2023 02:18

sohami requested changes Apr 17, 2023

View reviewed changes

adriens mentioned this pull request Apr 19, 2023

❔ RMAN/pg_barman backup/recovery management like solution to manage backups (at scale) 💾 #7240

Closed

This was referenced May 10, 2023

[Snapshot Interop] Add Changes in Snapshot Status Flow for remote sto… #7495

Merged

Add Changes in Snapshot Clone Flow for remote store interoperability. #7496

Merged

Add Changes in Snapshot Delete Flow for remote store interoperability. #7497

Merged

harishbhakuni force-pushed the createSnapFlow branch from 3d5402b to 479ba28 Compare May 10, 2023 21:48

harishbhakuni force-pushed the createSnapFlow branch from f2eff60 to 7f84c24 Compare June 7, 2023 14:32

Bukhtawar reviewed Jun 7, 2023

View reviewed changes

server/src/main/java/org/opensearch/snapshots/SnapshotShardsService.java Outdated Show resolved Hide resolved

Bukhtawar reviewed Jun 7, 2023

View reviewed changes

server/src/main/java/org/opensearch/snapshots/SnapshotsService.java Outdated Show resolved Hide resolved

Harish Bhakuni added 8 commits June 7, 2023 14:30

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote sto…

8430611

…re interoperability. Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

Address PR Comments.

3fcedb7

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

Address PR Comments and add tests for create snapshot api

bec444b

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

Address PR Comments and improve Test Coverage

b8b63ba

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

Address PR Comments

8163f45

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

Address PR Comments

b021371

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

Address PR Comments

fe70d7d

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

Address PR Comments

c3ef955

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

harishbhakuni force-pushed the createSnapFlow branch from 7f84c24 to c3ef955 Compare June 7, 2023 21:31

sohami approved these changes Jun 7, 2023

View reviewed changes

gbbafna approved these changes Jun 8, 2023

View reviewed changes

server/src/main/java/org/opensearch/cluster/SnapshotsInProgress.java Show resolved Hide resolved

gbbafna merged commit 1803fd9 into opensearch-project:main Jun 8, 2023

dblock pushed a commit to dblock/OpenSearch that referenced this pull request Jun 8, 2023

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote sto…

5f6aa30

…re interoperability. (opensearch-project#7118) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

sandeshkr419 pushed a commit to sandeshkr419/OpenSearch that referenced this pull request Jun 8, 2023

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote sto…

0bdedb5

…re interoperability. (opensearch-project#7118) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

harishbhakuni mentioned this pull request Jun 15, 2023

[Backport 2.x] [Snapshot Interop] Add Changes in Create Snapshot Flow… #8071

Merged

6 tasks

zhichao-aws mentioned this pull request Jun 26, 2023

[BUG] integTest failed due to compileTestKotlin FAILED. Introduced by changes of create snapshot workflow in core opensearch-project/index-management#824

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. #7118

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. #7118

Uh oh!

harishbhakuni commented Apr 12, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Apr 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 7, 2023

Uh oh!

github-actions bot commented Jun 7, 2023

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 7, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. #7118

[Snapshot Interop] Add Changes in Create Snapshot Flow for remote store interoperability. #7118

Uh oh!

Conversation

harishbhakuni commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Check List

Uh oh!

github-actions bot commented Apr 12, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 7, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Jun 7, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 7, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

harishbhakuni commented Apr 12, 2023 •

edited

Loading