Skip to content

Conversation

@kasundra07
Copy link
Contributor

@kasundra07 kasundra07 commented May 10, 2023

Description

Changes in Snapshot Status API required for Snapshot interoperability with Remote Store.

Related Issues

This change is dependent on Lock Manager changes and Create Snapshot API changes.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kasundra07 kasundra07 requested a review from dbwiddis as a code owner June 5, 2023 16:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@kasundra07 kasundra07 force-pushed the snapshotStatus branch 2 times, most recently from ac9c590 to b0db5a4 Compare June 5, 2023 18:23
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithoutInvokeFlush
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithoutInvokeFlush
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessOnSecondAttempt
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testReuseInFileBasedPeerRecovery

…re interoperability.

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Contributor

gbbafna commented Jul 11, 2023

All the test failures are flaky .

Test Result (5 failures / +4)

    org.opensearch.remotestore.RemoteStoreBackpressureIT.testWritesRejectedDueToTimeLagBreach
    org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testCancellation
    org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testCancellation
    org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testCancellation
    org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testCancellation

@gbbafna gbbafna merged commit a5752cb into opensearch-project:main Jul 11, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jul 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
#7495)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
(cherry picked from commit a5752cb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Jul 11, 2023
#7495) (#8612)

(cherry picked from commit a5752cb)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90 referenced this pull request in raghuvanshraj/OpenSearch Jul 12, 2023
…… (#7495)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
opensearch-project#7495)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
opensearch-project#7495)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants