-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Lcopt - An interactive tool for creating fully parameterised Life Cycle Assessment (LCA) foreground models #339
Comments
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @amoeba it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
I can participate in this review, but currently on vacation without a computer or reliable internet until August 8th. |
Thanks @cmutel. I'm going through the basics right now and would really appreciate it if you could check whatever you have time for but at least the functionality item of the review checklist. I should be able to do the rest. |
I had a chance to sit down with this over the weekend and things are looking great. I'm not quite done but I expect to be able to finish it by the end of the week here. |
Hey @pjamesjoyce this looks great now. Thanks for responding to the two issues I raised on the repository. I've checked off everything in the reviewer checklist, including the functionality item. If @cmutel could take a second look, I would very much appreciate the help with that item. Otherwise, everything looks great. Kudos for the extensive documentation and creating a very nice interactive tool. It looks like it represents a great deal of work and I had no troubles using it. @katyhuff I give this submission an Accept. With respect to functionality, I've verified the software does what it says it does to the best of my knowledge but I accept that my knowledge of LCA is limited. If you'd prefer to get a topical expert review from @cmutel I'd gladly change withhold my Accept until that's been done. What do you think? |
Thanks @amoeba for your review efforts and @pjamesjoyce for your prompt cooperation! I would love it if @cmutel could give this a final expert glance. I think has just gotten back into a space with internet in the last few days. |
Thanks @cmutel. When those have been resolved, can you and @pjamesjoyce update us here? |
I've referenced the issues to here so they're all in one place. |
That all looks great. Thanks for helping out @cmutel. And thanks for the quick responses to edits, @pjamesjoyce. I'm good here and I approve this submission. cc @katyhuff And, as I said before, this is a really well put-together piece of software, especially the polished nature of the UI and the highly-detailed docs. Well done! |
Thank you @amoeba and @cmutel for your thorough review. And, of course, thank you @pjamesjoyce , for your submission. @pjamesjoyce - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission. |
@whedon set 10.5281/zenodo.848529 as archive |
OK. 10.5281/zenodo.848529 is the archive. |
@arfon we are ready to accept this paper, thanks! |
@amoeba many thanks for your review here and to @katyhuff for editing this submission ✨ @pjamesjoyce - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00339 ⚡️ 🚀 💥 |
Thank you all for your time and effort. Much appreciated! 😃 |
Submitting author: @pjamesjoyce (P. James Joyce)
Repository: https://github.com/pjamesjoyce/lcopt
Version: v0.4.2
Editor: @katyhuff
Reviewer: @amoeba
Archive: 10.5281/zenodo.848529
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer questions
@amoeba, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @katyhuff know.
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: