Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global parameters can have null descriptions (names) #12

Closed
cmutel opened this issue Aug 18, 2017 · 2 comments
Closed

Global parameters can have null descriptions (names) #12

cmutel opened this issue Aug 18, 2017 · 2 comments

Comments

@cmutel
Copy link

cmutel commented Aug 18, 2017

This is confusing (especially selecting them afterwards). It doesn't seem like it is editable afterwards, either.
Pop-up uses "Description", but table uses "Name".

@pjamesjoyce
Copy link
Owner

I've added some client side validation to stop users from being able to enter null values where they shouldn't. You now get a message telling you what you need to do.

I've also made is so IDs that can't be parsed are automatically changed to useable ones (e.g. Useless Parameter! --> useless_parameter) and changed the form to refer to ID and Name instead of Name and Description.

@pjamesjoyce
Copy link
Owner

Link this issue to openjournals/joss-reviews#339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants