Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pathways: life cycle assessment of energy transition scenarios #6814

Closed
editorialbot opened this issue May 30, 2024 · 53 comments
Closed
Assignees
Labels
pre-review Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 30, 2024

Submitting author: @romainsacchi (Romain Sacchi)
Repository: https://github.com/polca/pathways
Branch with paper.md (empty if default branch):
Version: 0.0.1
Editor: @fraukewiese
Reviewers: @kcerva, @marc-vdm
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a454a9fc23453212416645423ab487a8"><img src="https://joss.theoj.org/papers/a454a9fc23453212416645423ab487a8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a454a9fc23453212416645423ab487a8/status.svg)](https://joss.theoj.org/papers/a454a9fc23453212416645423ab487a8)

Author instructions

Thanks for submitting your paper to JOSS @romainsacchi. Currently, there isn't a JOSS editor assigned to your paper.

@romainsacchi if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels May 30, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.rser.2022.112311 is OK
- 10.21105/joss.00236 is OK
- 10.1016/j.gloenvcha.2016.05.009 is OK
- 10.1007/s11367-021-01954-6 is OK
- 10.1016/j.jclepro.2019.118614 is OK
- 10.1038/s41560-017-0032-9 is OK
- 10.1088/1748-9326/aa914d is OK
- 10.1021/acs.est.5b01558 is OK
- 10.1007/s11367-016-1087-8 is OK
- 10.1016/j.spc.2018.07.001 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1111/jiec.12825 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=2.75 s (22.5 files/s, 78268.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             2             12              2         130743
YAML                            13             47             29          71057
JSON                             2              0              0           2373
Python                          18            555            627           2131
Jupyter Notebook                 9              0           6375            819
Markdown                         2             99              0            259
TeX                              1             12              0            128
CSV                             14              0              0            114
INI                              1              0              0              4
-------------------------------------------------------------------------------
SUM:                            62            725           7033         207628
-------------------------------------------------------------------------------

Commit count by author:

   168	romainsacchi
    26	alvarojhahn

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1069

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Alvaro Hahn-Menacho, perhaps the affiliations index need quoting?.

@kyleniemeyer
Copy link

Hello @romainsacchi, unfortunately we do not have any editors available to handle your submission right now, so I have to put this on our waitlist until someone frees up.

In the meantime, reviewer recommendations would be welcome (just please don't formally tag anyone with @).

In addition, to fix the paper compilation issue, please put quotations around the affiliation field with multiple numbers: affiliation: "1,2"

@kyleniemeyer kyleniemeyer added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 30, 2024
@romainsacchi
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@romainsacchi
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @romainsacchi, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@romainsacchi
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=2.39 s (23.0 files/s, 33921.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
YAML                            13             47             29          71057
JSON                             2              0              0           2373
Python                          18            555            627           2131
Jupyter Notebook                 4              0           3145            511
Markdown                         2             99              0            259
TeX                              1             12              0            128
CSV                             14              0              0            114
INI                              1              0              0              4
-------------------------------------------------------------------------------
SUM:                            55            713           3801          76577
-------------------------------------------------------------------------------

Commit count by author:

   172	romainsacchi
    26	alvarojhahn

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1069

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@romainsacchi
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.rser.2022.112311 is OK
- 10.21105/joss.00236 is OK
- 10.1016/j.gloenvcha.2016.05.009 is OK
- 10.1007/s11367-021-01954-6 is OK
- 10.1111/jiec.12825 is OK
- 10.1016/j.jclepro.2019.118614 is OK
- 10.1038/s41560-017-0032-9 is OK
- 10.1088/1748-9326/aa914d is OK
- 10.1021/acs.est.5b01558 is OK
- 10.1007/s11367-016-1087-8 is OK
- 10.1016/j.spc.2018.07.001 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@arfon
Copy link
Member

arfon commented Jun 23, 2024

@editorialbot generate pdf

☝ to generate the most similar paper recommendation list which has been broken for some time.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Brightway: An open source framework for Life Cycle Assessment
Submitting author: @cmutel
Handling editor: @katyhuff (Retired)
Reviewers: @amoeba
Similarity score: 0.8405

unfold: removing the barriers to sharing and reproducing prospective life-cycle assessment databases
Submitting author: @romainsacchi
Handling editor: @fraukewiese (Active)
Reviewers: @mfastudillo, @MaximeAgez
Similarity score: 0.8303

ELDAM: A Python software for Life Cycle Inventory data management
Submitting author: @GustaveCoste
Handling editor: @sjpfenninger (Retired)
Reviewers: @konstantinstadler, @romainsacchi
Similarity score: 0.8226

Lcopt - An interactive tool for creating fully parameterised Life Cycle Assessment (LCA) foreground models
Submitting author: @pjamesjoyce
Handling editor: @katyhuff (Retired)
Reviewers: @amoeba
Similarity score: 0.8203

Temporalis: an open source software for dynamic LCA
Submitting author: @cardosan
Handling editor: @arfon (Active)
Reviewers: @pjamesjoyce
Similarity score: 0.8164

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@romainsacchi
Copy link

Hello @arfon, anything I can do to help moving the process along?

@kyleniemeyer
Copy link

@editorialbot invite @fraukewiese as editor

Hello @fraukewiese, could you edit this submission? Thank you!

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@fraukewiese
Copy link

Yes, I can edit this submission.

@fraukewiese
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @fraukewiese is now the editor

@kyleniemeyer kyleniemeyer removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 24, 2024
@romainsacchi
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Temporalis: an open source software for dynamic LCA
Submitting author: @cardosan
Handling editor: @arfon (Active)
Reviewers: @pjamesjoyce
Similarity score: 0.7272

WorldDynamics.jl: A Julia Package for Developing and Simulating Integrated Assessment Models
Submitting author: @aurorarossi
Handling editor: @fraukewiese (Active)
Reviewers: @ranocha, @StanczakDominik, @miguelraz
Similarity score: 0.7201

Mat-dp: An open-source Python model for analysing material demand projections and their environmental implications, which result from building low-carbon systems.
Submitting author: @kcerva
Handling editor: @crvernon (Active)
Reviewers: @MoLi7, @nick-gorman
Similarity score: 0.7181

PySD: System Dynamics Modeling in Python
Submitting author: @rogersamso
Handling editor: @pdebuyl (Active)
Reviewers: @blsqr, @sixpearls
Similarity score: 0.7135

autumn: A Python library for dynamic modelling of captured CO_2 cost potential curves
Submitting author: @Eugenio2192
Handling editor: @timtroendle (Retired)
Reviewers: @igarizio, @milicag
Similarity score: 0.7128

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@fraukewiese
Copy link

@ClaraBuettner, @@kcerva, @mkvdhulst
– would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is pathways: life cycle assessment of energy transition

@kcerva
Copy link

kcerva commented Aug 5, 2024

@fraukewiese The topic seems relevant to me, however could you please advise on expectations regarding review deadline? So I decide based on my workload.

@fraukewiese
Copy link

@kcerva : Thanks a lot for your answer. Usually, the review process is expected to take around 6 weeks. However, since we still need to find a second reviewer, it might also take longer. When do you think you would be able to work on the review?

@fraukewiese
Copy link

fyi: I am out of office now for 3 weeks and will be back beginning of September

@fraukewiese
Copy link

@kcerva : Do you think you would be available for the review during the next 2-3 months?

@fraukewiese
Copy link

@marc-vdm @aurorarossi
– would one of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is pathways: life cycle assessment of energy transition

@marc-vdm
Copy link

marc-vdm commented Sep 5, 2024

@kcerva : Do you think you would be available for the review during the next 2-3 months?

@fraukewiese Would this be timeline for me as well? In that case, I'd be happy to accept.

edit: 6 weeks mentioned above is also fine, it's just last time I was asked for review -for another Journal- they wanted a much shorter timeline.

@aurorarossi
Copy link

Hello @fraukewiese unfortunately, at the moment I do not have time to review this work. Thank you!

@fraukewiese
Copy link

@kcerva : Thank you very much! The goal is to finish a review within 6 weeks, including the iteration steps of the reviewers making improvement suggestions and the authors reacting to those and adapting code and paper. This can also already start step-by-step during the process of reviewing. So your review does not have to be finished before already suggestion points for improvement to the authors or questions you might have in the review threat. However, this might take longer that the 6 weeks, so probably 2-3 months is more realistic, also because we still need to find a second reviewer. Thus, I will make you reviewer now but the actual review will start as soon as we have found a second reviewer and I will notify you here in this thread.

@fraukewiese
Copy link

@editorialbot add @kcerva as reviewer

@editorialbot
Copy link
Collaborator Author

@kcerva added to the reviewers list!

@fraukewiese
Copy link

@rogersamso , @mfastudillo
– would one of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is pathways: life cycle assessment of energy transition

@marc-vdm
Copy link

@fraukewiese I'm seeing these comments and I wonder if you accidentally meant me but mixed the names up?

@fraukewiese
Copy link

@marc-vdm : Thanks, yes I think you are right. Sorry for mixing it up! I will make you a reviewer then :)

@fraukewiese I'm seeing these comments and I wonder if you accidentally meant me but mixed the names up?

@fraukewiese
Copy link

@editorialbot add @marc-vdm as reviewer

@editorialbot
Copy link
Collaborator Author

@marc-vdm added to the reviewers list!

@fraukewiese
Copy link

@kcerva : Thank you very much! The goal is to finish a review within 6 weeks, including the iteration steps of the reviewers making improvement suggestions and the authors reacting to those and adapting code and paper. This can also already start step-by-step during the process of reviewing. So your review does not have to be finished before already suggestion points for improvement to the authors or questions you might have in the review threat. However, this might take longer that the 6 weeks, so probably 2-3 months is more realistic, also because we still need to find a second reviewer. Thus, I will make you reviewer now but the actual review will start as soon as we have found a second reviewer and I will notify you here in this thread.

@kcerva : I have mixed the the answer from @marc-vdm up with you, that's why I made you a reviewer already. Sorry for that! However, would you still be willing to review this submission taking into consideration my answer about the deadlines? :)

@kcerva
Copy link

kcerva commented Oct 1, 2024

@fraukewiese sorry, I missed the last few messages due to an intense workload. I can do the review, yes. Thanks.

@fraukewiese
Copy link

@kcerva : Great, thanks for agreeing to review!

@fraukewiese
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7309.

@fraukewiese
Copy link

@kcerva @marc-vdm – many thanks for agreeing to review here! See you over in #7309 where the actual review will take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 3 (PE) Physics and Engineering
Projects
None yet
Development

No branches or pull requests

8 participants