Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ipcc - a Python package for the calculation of national greenhouse gas inventories #6069

Closed
editorialbot opened this issue Nov 20, 2023 · 29 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 20, 2023

Submitting author: @mabudz (Maik Budzinski)
Repository: https://gitlab.com/bonsamurais/bonsai/util/ipcc
Branch with paper.md (empty if default branch): joss
Version: v0.2.0
Editor: @pdebuyl
Reviewers: @GISWLH, @PennyHow
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d193aff8fe402e6fa597d7dc1b0538f6"><img src="https://joss.theoj.org/papers/d193aff8fe402e6fa597d7dc1b0538f6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d193aff8fe402e6fa597d7dc1b0538f6/status.svg)](https://joss.theoj.org/papers/d193aff8fe402e6fa597d7dc1b0538f6)

Author instructions

Thanks for submitting your paper to JOSS @mabudz. Currently, there isn't a JOSS editor assigned to your paper.

@mabudz if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Nov 20, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.14 s (467.1 files/s, 165906.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
YAML                             4             26             39           7975
Python                          40           1806           2976           6355
Markdown                        13            161              0            503
Jupyter Notebook                 3              0           2461            230
INI                              1             11              0             81
TeX                              1              5              0             63
make                             1              6              8             15
TOML                             1              1              3              5
-------------------------------------------------------------------------------
SUM:                            64           2016           5487          15227
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1454

@editorialbot
Copy link
Collaborator Author

Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1080/07350015.2015.1038545 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1111/jiec.12713 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1111/jiec.12715 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

pyhector: A Python interface for the simple climate model Hector
Submitting author: @swillner
Handling editor: @arfon (Active)
Reviewers: @sgrieve
Similarity score: 0.8204

pyam: a Python Package for the Analysis and Visualization of Models of the Interaction of Climate, Human, and Environmental Systems
Submitting author: @gidden
Handling editor: @lheagy (Retired)
Reviewers: @jtmiclat, @Chilipp
Similarity score: 0.8179

epipack: An infectious disease modeling package for Python
Submitting author: @benmaier
Handling editor: @fboehm (Active)
Reviewers: @chrisvoncsefalvay, @esteinig
Similarity score: 0.8153

Pymagicc: A Python wrapper for the simple climate model MAGICC
Submitting author: @rgieseke
Handling editor: @arfon (Active)
Reviewers: @sgrieve
Similarity score: 0.8138

gdess: A framework for evaluating simulated atmospheric CO₂ in Earth System Models
Submitting author: @dkauf42
Handling editor: @dhhagan (Active)
Reviewers: @slayoo, @simonom
Similarity score: 0.8134

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

Hello @mabudz, while we are using this pre-review issue to get started and find an editor and reviewers, can you address the issues with your paper mentioned above? Specifically, the lack of a Statement of Need section, and the DOI errors.

@mabudz
Copy link

mabudz commented Nov 21, 2023

Hi @kyleniemeyer , I pushed the correction for the dois and added the statement of need section.

@mabudz
Copy link

mabudz commented Nov 29, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Pymagicc: A Python wrapper for the simple climate model MAGICC
Submitting author: @rgieseke
Handling editor: @arfon (Active)
Reviewers: @sgrieve
Similarity score: 0.8122

flux-data-qaqc: A Python Package for Energy Balance Closure and Post-Processing of Eddy Flux Data
Submitting author: @JohnVolk
Handling editor: @pdebuyl (Active)
Reviewers: @ashwinvis, @dgketchum
Similarity score: 0.8111

Lcopt - An interactive tool for creating fully parameterised Life Cycle Assessment (LCA) foreground models
Submitting author: @pjamesjoyce
Handling editor: @katyhuff (Retired)
Reviewers: @amoeba
Similarity score: 0.8089

epipack: An infectious disease modeling package for Python
Submitting author: @benmaier
Handling editor: @fboehm (Active)
Reviewers: @chrisvoncsefalvay, @esteinig
Similarity score: 0.8077

pyam: a Python Package for the Analysis and Visualization of Models of the Interaction of Climate, Human, and Environmental Systems
Submitting author: @gidden
Handling editor: @lheagy (Retired)
Reviewers: @jtmiclat, @Chilipp
Similarity score: 0.8075

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/jiec.12713 is OK
- 10.1111/jiec.12715 is OK
- 10.1080/07350015.2015.1038545 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@kyleniemeyer
Copy link

Thanks @mabudz! The paper looks in good shape now.

Unfortunately, we do not have any editors available to handle this right now, so I have to put it on our backlog. We will get it moving once someone frees up.

@kyleniemeyer kyleniemeyer added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 30, 2023
@pdebuyl
Copy link

pdebuyl commented Dec 1, 2023

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @pdebuyl is now the editor

@kyleniemeyer kyleniemeyer removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Dec 1, 2023
@pdebuyl
Copy link

pdebuyl commented Dec 4, 2023

@GISWLH would you review this article for the Journal of Open Source Software ?

@pdebuyl
Copy link

pdebuyl commented Dec 4, 2023

@PennyHow would you review this article for the Journal of Open Source Software ?

@GISWLH
Copy link

GISWLH commented Dec 4, 2023

Thanks for your invitation @pdebuyl , I'd like to review this article.

@pdebuyl
Copy link

pdebuyl commented Dec 4, 2023

Thanks @GISWLH :-)

@pdebuyl
Copy link

pdebuyl commented Dec 4, 2023

@editorialbot add @GISWLH as reviewer

@editorialbot
Copy link
Collaborator Author

@GISWLH added to the reviewers list!

@PennyHow
Copy link

PennyHow commented Dec 5, 2023

Looks interesting! I'd be happy to review this @pdebuyl

@pdebuyl
Copy link

pdebuyl commented Dec 5, 2023

Thanks @PennyHow :-)

@pdebuyl
Copy link

pdebuyl commented Dec 5, 2023

@editorialbot add @PennyHow as reviewer

@editorialbot
Copy link
Collaborator Author

@PennyHow added to the reviewers list!

@pdebuyl
Copy link

pdebuyl commented Dec 5, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants