8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null

[MBaesken]

On Linux x86_64 fastdebug with ubsan enabled we run into this error because we call qsort with a first parameter that is null.

/jdk/src/hotspot/share/utilities/growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
#0 0x150d701bb4b1 in GrowableArrayView<nmethod*>::sort(int ()(nmethod**, nmethod**)) /jdk/src/hotspot/share/utilities/growableArray.hpp:290
#1 0x150d701bb4b1 in ClassUnloadingContext::free_nmethods() /jdk/src/hotspot/share/gc/shared/classUnloadingContext.cpp:159
#2 0x150d71f5cca3 in G1CollectedHeap::unload_classes_and_code(char const, BoolObjectClosure*, GCTimer*) /jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:2538
#3 0x150d71ffb009 in G1FullCollector::phase1_mark_live_objects() /jdk/src/hotspot/share/gc/g1/g1FullCollector.cpp:330
#4 0x150d71ffc675 in G1FullCollector::collect() /jdk/src/hotspot/share/gc/g1/g1FullCollector.cpp:209
#5 0x150d71f3e593 in G1CollectedHeap::do_full_collection(bool, bool) /jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:842
#6 0x150d71f5b12d in G1CollectedHeap::satisfy_failed_allocation_helper(unsigned long, bool, bool, bool, bool*) /jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:917
#7 0x150d71f5b3dc in G1CollectedHeap::satisfy_failed_allocation(unsigned long, bool*) /jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:930
#8 0x150d721835f7 in VM_G1CollectForAllocation::doit() /jdk/src/hotspot/share/gc/g1/g1VMOperations.cpp:127
#9 0x150d74291ec8 in VM_Operation::evaluate() /jdk/src/hotspot/share/runtime/vmOperations.cpp:75
#10 0x150d742ca1be in VMThread::evaluate_operation(VM_Operation*) /jdk/src/hotspot/share/runtime/vmThread.cpp:283
#11 0x150d742cb9e7 in VMThread::inner_execute(VM_Operation*) /jdk/src/hotspot/share/runtime/vmThread.cpp:427
#12 0x150d742cc601 in VMThread::loop() /jdk/src/hotspot/share/runtime/vmThread.cpp:493
#13 0x150d742cc601 in VMThread::loop() /jdk/src/hotspot/share/runtime/vmThread.cpp:478

seems we sometimes call qsort with nullptr as first parameter, this is not recommended.
When adding a guarantee the same can be seen (_data is null).
So better add a check and do not sort, if there is nothing provided to be sorted .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null

Issue

• JDK-8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null (Bug - P4)

Reviewers

• Johan Sjölen (@jdksjolen - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19283/head:pull/19283
$ git checkout pull/19283

Update a local copy of the PR:
$ git checkout pull/19283
$ git pull https://git.openjdk.org/jdk.git pull/19283/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19283

View PR using the GUI difftool:
$ git pr show -t 19283

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19283.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null

Reviewed-by: jsjolen, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 5f2b8d0: 8332448: Make SpaceMangler inherit AllStatic
• 8a49d47: 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
• ce99198: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
• f5ab7df: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
• 9f77793: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
• fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
• 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments
• b78613b: 8332154: Memory leak in SynchronousQueue
• 7652f98: 8331885: C2: meet between unloaded and speculative types is not symmetric
• d6b7f9b: 8331851: Add specific regression leap year tests for Calendar.roll()
• ... and 7 more: https://git.openjdk.org/jdk/compare/9bb6169a1cba900fa79d63119696efe265762083...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (233991b0)

[jdksjolen]

Right, because GrowableArray will not allocate anything when the passed in capacity is 0 and will set the data pointer to null. This turns out not to be a problem in practice, as the length of the array is 0 (and so the pointer should not be dereferenced). I'm OK with this.

[MBaesken]

Hi Johan, thanks for the review .

btw seems I found a similar one

/jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null
    #0 0x7fd95bec78d8 in spawnChild /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562
    #1 0x7fd95bec78d8 in startChild /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:612
    #2 0x7fd95bec78d8 in Java_java_lang_ProcessImpl_forkAndExec /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:712
    #3 0x7fd93797a06d  (<unknown module>)

but here it is memcpy not qsort .
memcpy(buf+offset, c->pdir, sp.dirlen); gets a second parameter null.
Something similar was discussed and fixed here https://bugs.python.org/issue27570 for Python .

More info can be found here bellard/quickjs#225

[MBaesken]

/integrate

[openjdk]

Going to push as commit e529101.
Since your change was applied there have been 19 commits pushed to the master branch:

• 414a7fd: 8311175: Move BufWriter::asByteBuffer to BufWriterImpl
• 451cc23: 8332486: ClassFile API ArrayIndexOutOfBoundsException with label metadata
• 5f2b8d0: 8332448: Make SpaceMangler inherit AllStatic
• 8a49d47: 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
• ce99198: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
• f5ab7df: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
• 9f77793: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
• fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
• 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments
• b78613b: 8332154: Memory leak in SynchronousQueue
• ... and 9 more: https://git.openjdk.org/jdk/compare/9bb6169a1cba900fa79d63119696efe265762083...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit e529101.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[magicus]

@MBaesken Thank you for your efforts of making the ubsan actually usable!