-
Notifications
You must be signed in to change notification settings - Fork 6.1k
dummy: fix 'objectmonitor' -> 'ObjectMonitor' typos. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome to the OpenJDK organization on GitHub! This repository is currently a read-only git mirror of the official Mercurial repository (located at https://hg.openjdk.java.net/). As such, we are not currently accepting pull requests here. If you would like to contribute to the OpenJDK project, please see https://openjdk.java.net/contribute/ on how to proceed. This pull request will be automatically closed. |
|
The auto-close since the repo is a read-only mirror is cool. I did expect something to squawk at me since I submitted a changeset comment that would not pass jcheck: dummy: fix 'objectmonitor' -> 'ObjectMonitor' typos. but that didn't happen. Is this something that would have happened if the destination repo was actually live? |
|
When the Skara PR bot runs |
|
So the Skara PR bot would have rejected the pull request due to the bad title which is the same as the first line of (old style) commit message right? (Just trying to understand how the new thing works)... |
|
Yes, the PR title is what will be used as the first line of the commit. Btw, it wouldn't have actually rejected it, it would just have noted that it didn't have a proper issue ID, so no rfr yet. |
|
Here is an example of one without a valid subject: Here is one with a valid subject for comparison: |
|
Hello, I don't really know where to put this, besides https://bugreport.java.com/bugreport/ but that says I've been encountering some issue building openjdk 16 lately (for a few days) where I get the error: The bug is reproducible with openjdk 16 being the bootjdk, openjdk 14 as the boot jdk compiles fine. I know commenting on a PR to ask for help/report a bug isn't what you're supposed to do, but I don't really know where else to put this. If there's a better place for me to report this, please tell me. If there isn't a better place to report it (there probably is), maybe a blank github repo could be created to report bugs that don't fall under the umbrella of those terms on https://bugreport.java.com/bugreport |
|
Anyone know where I can properly report that error? |
Fix build after merge with master
…e and added test (openjdk#10)
Co-authored-by: Xin Liu <xxinliu@amazon.com>
Merge master into bsd-port
Test pull request that I'm planning to delete if I can figure out how to do that.