Skip to content

Conversation

@dcubed-ojdk
Copy link
Member

Test pull request that I'm planning to delete if I can figure out how to do that.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2020

Welcome to the OpenJDK organization on GitHub!

This repository is currently a read-only git mirror of the official Mercurial repository (located at https://hg.openjdk.java.net/). As such, we are not currently accepting pull requests here. If you would like to contribute to the OpenJDK project, please see https://openjdk.java.net/contribute/ on how to proceed.

This pull request will be automatically closed.

@bridgekeeper bridgekeeper bot closed this Aug 26, 2020
@dcubed-ojdk
Copy link
Member Author

The auto-close since the repo is a read-only mirror is cool. I did expect something to squawk at me since I submitted a changeset comment that would not pass jcheck:

dummy: fix 'objectmonitor' -> 'ObjectMonitor' typos.

but that didn't happen. Is this something that would have happened if the destination repo was actually live?

@kevinrushforth
Copy link
Member

When the Skara PR bot runs jcheck it doesn't check the commit message (doesn't care). What it would have complained about was the fact that your PR title didn't start with a Bug ID.

@dcubed-ojdk
Copy link
Member Author

So the Skara PR bot would have rejected the pull request due to the bad title which is the same as the first line of (old style) commit message right? (Just trying to understand how the new thing works)...

@kevinrushforth
Copy link
Member

Yes, the PR title is what will be used as the first line of the commit. Btw, it wouldn't have actually rejected it, it would just have noted that it didn't have a proper issue ID, so no rfr yet.

@kevinrushforth
Copy link
Member

Here is an example of one without a valid subject:
openjdk/jfx#185

Here is one with a valid subject for comparison:
openjdk/jfx#288

@Titaniumtown
Copy link

Hello, I don't really know where to put this, besides https://bugreport.java.com/bugreport/ but that says This page is for reporting bugs in implementations of the Java Platform, Standard Edition, as distributed on the Java Development Kit Builds page but my bug is about failing to build openjdk, which doesn't seem to apply. I run a repository for Arch Linux Arm focused towards the Raspberry Pi 4 aarch64 kernel builds (which aren't officially supported, but works fine). I also provide a package for openjdk 15 and the HEAD of openjdk (atm openjdk 16).

I've been encountering some issue building openjdk 16 lately (for a few days) where I get the error:

Building targets 'images legacy-jre-image' in configuration 'linux-aarch64-server-release'
Creating support/modules_libs/java.base/server/libjvm.so from 1004 file(s)
/mnt/hdd/raspi4_pkgbuilds/java-openjdk-git/src/jdk/src/java.base/share/classes/java/lang/Double.java:104: error: floating point number too small
    public static final double MIN_VALUE = 0x0.0000000000001P-1022; // 4.9e-324
                                           ^
/mnt/hdd/raspi4_pkgbuilds/java-openjdk-git/src/jdk/src/java.base/share/classes/java/lang/Float.java:101: error: floating point number too small
    public static final float MIN_VALUE = 0x0.000002P-126f; // 1.4e-45f

The bug is reproducible with openjdk 16 being the bootjdk, openjdk 14 as the boot jdk compiles fine.
I don't know were else to report it because the official bug report page is about the distributed builds, and not errors while compiling it.

I know commenting on a PR to ask for help/report a bug isn't what you're supposed to do, but I don't really know where else to put this. If there's a better place for me to report this, please tell me. If there isn't a better place to report it (there probably is), maybe a blank github repo could be created to report bugs that don't fall under the umbrella of those terms on https://bugreport.java.com/bugreport
Thanks!

@Titaniumtown
Copy link

Anyone know where I can properly report that error?

@dcubed-ojdk dcubed-ojdk deleted the dummy branch August 27, 2020 21:11
VladimirKempik added a commit to VladimirKempik/jdk that referenced this pull request Mar 4, 2021
cushon pushed a commit to cushon/jdk that referenced this pull request Apr 2, 2021
JimLaskey pushed a commit to JimLaskey/jdk that referenced this pull request Nov 18, 2022
asotona added a commit to asotona/jdk that referenced this pull request Feb 6, 2023
fisk pushed a commit to fisk/jdk that referenced this pull request Feb 6, 2023
caojoshua pushed a commit to caojoshua/jdk that referenced this pull request Mar 21, 2023
Co-authored-by: Xin Liu <xxinliu@amazon.com>
lahodaj referenced this pull request in lahodaj/jdk Nov 27, 2024
snake66 pushed a commit to snake66/jdk that referenced this pull request Oct 14, 2025
swesonga pushed a commit to swesonga/jdk that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants