8332960: ubsan: classListParser.hpp:159:12: runtime error: load of value 2101478704, which is not a valid value for type 'ParseMode'

[MBaesken]

When running with ubsan enabled binaries, the following error occurs in some jtreg tests :

/jdk/src/hotspot/share/cds/classListParser.hpp:159:12: runtime error: load of value 2101478704, which is not a valid value for type 'ParseMode'
#0 0x7fff7920f3dc in ClassListParser::ClassListParser(char const*, ClassListParser::ParseMode) (/images/jdk/lib/server/libjvm.so+0x534f3dc)
#1 0x7fff7af824b8 in MetaspaceShared::preload_classes(JavaThread*) (/images/jdk/lib/server/libjvm.so+0x70c24b8)
#2 0x7fff7af8ffa8 in MetaspaceShared::preload_and_dump_impl(JavaThread*) (/images/jdk/lib/server/libjvm.so+0x70cffa8)
#3 0x7fff7af90978 in MetaspaceShared::preload_and_dump() (/images/jdk/lib/server/libjvm.so+0x70d0978)
#4 0x7fff7bf4c7f4 in Threads::create_vm(JavaVMInitArgs*, bool*) (/images/jdk/lib/server/libjvm.so+0x808c7f4)
#5 0x7fff7a5620b4 in JNI_CreateJavaVM (/images/jdk/lib/server/libjvm.so+0x66a20b4)
#6 0x7fff81073068 in InitializeJVM /jdk/src/java.base/share/native/libjli/java.c:1550
#7 0x7fff81073068 in JavaMain /jdk/src/java.base/share/native/libjli/java.c:491
#8 0x7fff8107ef1c in ThreadJavaMain /jdk/src/java.base/unix/native/libjli/java_md.c:642
#9 0x7fff80f99714 in start_thread (/lib64/libpthread.so.0+0x9714)
#10 0x7fff8034b774 in __GI___clone (/lib64/libc.so.6+0x13b774)

Seems _parse_mode is initialized too late.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332960: ubsan: classListParser.hpp:159:12: runtime error: load of value 2101478704, which is not a valid value for type 'ParseMode'

Issue

• JDK-8332960: ubsan: classListParser.hpp:159:12: runtime error: load of value 2101478704, which is not a valid value for type 'ParseMode' (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19411/head:pull/19411
$ git checkout pull/19411

Update a local copy of the PR:
$ git checkout pull/19411
$ git pull https://git.openjdk.org/jdk.git pull/19411/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19411

View PR using the GUI difftool:
$ git pr show -t 19411

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19411.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332960: ubsan: classListParser.hpp:159:12: runtime error: load of value 2101478704, which is not a valid value for type 'ParseMode'

Reviewed-by: dholmes, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 9a83dfe: 8332431: NullPointerException in JTable of SwingSet2
• 01060ad: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
• 673f767: 8285506: Unify os::vsnprintf implementations
• 91ab088: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails
• 9ac8d05: 8332228: TypePollution.java: Unrecognized VM option 'UseSecondarySuperCache'
• 91caec0: 8330542: Template for Creating Strict JAXP Configuration File
• da6aa2a: 8332849: Update doc/testing.{md,html} (spelling and stale information)
• b8f2ec9: 8195675: Call to insertText with single character from custom Input Method ignored
• 0f3e2cc: 8331670: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal
• 51ae08f: 8333093: Incorrect comment in zAddress_aarch64.cpp
• ... and 17 more: https://git.openjdk.org/jdk/compare/1b8dea4a9288c1518dc501a58d806c7365ea68b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (17ab6468)

[dholmes-ora]

Good catch!

[TheRealMDoerr]

LGTM.

[MBaesken]

Hi David and Martin, thanks for the reviews !

/integrate

[openjdk]

Going to push as commit b8ae11e.
Since your change was applied there have been 27 commits pushed to the master branch:

• 9a83dfe: 8332431: NullPointerException in JTable of SwingSet2
• 01060ad: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
• 673f767: 8285506: Unify os::vsnprintf implementations
• 91ab088: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails
• 9ac8d05: 8332228: TypePollution.java: Unrecognized VM option 'UseSecondarySuperCache'
• 91caec0: 8330542: Template for Creating Strict JAXP Configuration File
• da6aa2a: 8332849: Update doc/testing.{md,html} (spelling and stale information)
• b8f2ec9: 8195675: Call to insertText with single character from custom Input Method ignored
• 0f3e2cc: 8331670: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal
• 51ae08f: 8333093: Incorrect comment in zAddress_aarch64.cpp
• ... and 17 more: https://git.openjdk.org/jdk/compare/1b8dea4a9288c1518dc501a58d806c7365ea68b3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit b8ae11e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.