1234567: Scott walks in #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment is here
|
Welcome to the OpenJDK organization on GitHub! This repository is currently a read-only git mirror of the official Mercurial repository (located at https://hg.openjdk.java.net/). As such, we are not currently accepting pull requests here. If you would like to contribute to the OpenJDK project, please see https://openjdk.java.net/contribute/ on how to proceed. This pull request will be automatically closed. |
|
/help |
cushon
pushed a commit
to cushon/jdk
that referenced
this pull request
Apr 2, 2021
3 tasks
3 tasks
openjdk-notifier bot
pushed a commit
that referenced
this pull request
Sep 17, 2022
Adds a regression for DK-8293776 : Adds CSS 4 and 8 digits hex coded Color #13
franferrax
added a commit
to franferrax/jdk
that referenced
this pull request
Oct 4, 2022
Co-authored-by: Martin Balao <mbalao@redhat.com> Reviewed-by: @gnu-andrew
asotona
added a commit
to asotona/jdk
that referenced
this pull request
Oct 7, 2022
…Symbol (openjdk#13) refactored to FieldModel::fieldTypeSymbol and MethodModel::methodTypeSymbol (openjdk#13) added round testing of signatures in RebuildTransformation test helper
openjdk-notifier bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
Revert MemorySegment factories
franferrax
added a commit
to franferrax/jdk
that referenced
this pull request
Oct 28, 2022
openjdk#13 isn't a perfect revert of 0af22dc limited to SSLContextImpl.java and SunJSSE.java, since it doesn't remove the SharedSecrets import. This was already in this way in rh2020290-support_tls_1_3_in_fips.v1.patch, I'm now realizing this when doing the OpenJDK 11 backport and retrying the same approach in OpenJDK 17: ~~~ # Revert openjdk#13 git show 0bd5ca9 | git apply -R # Redo openjdk#13 by reverting 0af22dc in SSLContextImpl.java and SunJSSE.java git show 0af22dc | git apply -R --include=src/java.base/share/classes/sun/security/ssl/* ~~~ In openjdk#14, I forgot to delete the DHKF and DHKFLock static variables from FIPSKeyImporter, which are no longer used, see rh-openjdk#14 (comment).
gnu-andrew
pushed a commit
to gnu-andrew/jdk
that referenced
this pull request
Nov 23, 2022
openjdk#13 isn't a perfect revert of 0af22dc limited to SSLContextImpl.java and SunJSSE.java, since it doesn't remove the SharedSecrets import. This was already in this way in rh2020290-support_tls_1_3_in_fips.v1.patch, I'm now realizing this when doing the OpenJDK 11 backport and retrying the same approach in OpenJDK 17: ~~~ # Revert openjdk#13 git show 0bd5ca9 | git apply -R # Redo openjdk#13 by reverting 0af22dc in SSLContextImpl.java and SunJSSE.java git show 0af22dc | git apply -R --include=src/java.base/share/classes/sun/security/ssl/* ~~~ In openjdk#14, I forgot to delete the DHKF and DHKFLock static variables from FIPSKeyImporter, which are no longer used, see rh-openjdk#14 (comment). Reviewed-by: @gnu-andrew
asotona
added a commit
to asotona/jdk
that referenced
this pull request
Feb 6, 2023
…Symbol (openjdk#13) refactored to FieldModel::fieldTypeSymbol and MethodModel::methodTypeSymbol (openjdk#13) added round testing of signatures in RebuildTransformation test helper
robehn
pushed a commit
to robehn/jdk
that referenced
this pull request
Aug 15, 2023
It doesn't work as expected. Local testing didn't catch the failing cases. We really need the proper test suite.. Reverting for now, and once we've proper CI, I'll rework the original patch and make it work. This reverts commit 5be1125.
gnu-andrew
pushed a commit
to gnu-andrew/jdk
that referenced
this pull request
Aug 18, 2023
Co-authored-by: Martin Balao <mbalao@redhat.com> Reviewed-by: @gnu-andrew
gnu-andrew
pushed a commit
to gnu-andrew/jdk
that referenced
this pull request
Aug 18, 2023
openjdk#13 isn't a perfect revert of 0af22dc limited to SSLContextImpl.java and SunJSSE.java, since it doesn't remove the SharedSecrets import. This was already in this way in rh2020290-support_tls_1_3_in_fips.v1.patch, I'm now realizing this when doing the OpenJDK 11 backport and retrying the same approach in OpenJDK 17: ~~~ # Revert openjdk#13 git show 0bd5ca9 | git apply -R # Redo openjdk#13 by reverting 0af22dc in SSLContextImpl.java and SunJSSE.java git show 0af22dc | git apply -R --include=src/java.base/share/classes/sun/security/ssl/* ~~~ In openjdk#14, I forgot to delete the DHKF and DHKFLock static variables from FIPSKeyImporter, which are no longer used, see rh-openjdk#14 (comment). Reviewed-by: @gnu-andrew
This was referenced May 17, 2024
3 tasks
This was referenced Jun 4, 2024
This was referenced Jun 20, 2024
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
lahodaj
added a commit
to lahodaj/jdk
that referenced
this pull request
Feb 7, 2025
* An experiment on PatternType. * Fixing test. * Fixing build. * Fixing tests. * Cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment is here, just learning the system...