Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new [taxonomy].extended.json with extended synonyms #10744

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Aug 28, 2024

This creates a new .extended.json file for all taxonomies, that contain extended synonyms.
Fixes #10742

Notes:

  • synonyms_extended entries are normalized (no accents, capitals, all non letter chars turned to dashes etc.)
  • synonyms are not normalized (as in the normal export)
  • properties, parents, childrens are not included (they are in the .full export)
  • the .full export is not changed (it does not contain the extended synonyms)

Sample output in test taxonomy:

en:passion-fruit-yogurts: {
synonyms_extended: { },
normalized_synonyms: {
nl: [
"yoghurts-met-passievrucht"
],
en: [
"passion-fruit-yogurts"
],
fr: [
"yaourts-au-fruit-de-la-passion"
]
},
name: {
nl: "Yoghurts met passievrucht",
fr: "Yaourts au fruit de la passion",
en: "Passion fruit yogurts"
},
normalized_synonyms_extended: {
en: [
"passion-fruit-yoghurts",
"passion-fruit-yogurts",
"passionfruit-yoghurts",
"passionfruit-yogurts"
],
fr: [
"yaourts-au-fruit-de-la-fruits-de-la-passion",
"yaourts-au-fruit-de-la-maracuja",
"yaourts-au-fruit-de-la-passion",
"yaourts-au-fruits-de-la-passion",
"yaourts-au-maracuja",
"yaourts-au-passion",
"yoghourts-au-fruit-de-la-fruits-de-la-passion",
"yoghourts-au-fruit-de-la-maracuja",
"yoghourts-au-fruit-de-la-passion",
"yoghourts-au-fruits-de-la-passion",
"yoghourts-au-maracuja",
"yoghourts-au-passion",
"yogourts-au-fruit-de-la-fruits-de-la-passion",
"yogourts-au-fruit-de-la-maracuja",
"yogourts-au-fruit-de-la-passion",
"yogourts-au-fruits-de-la-passion",
"yogourts-au-maracuja",
"yogourts-au-passion"
],
nl: [
"yoghurts-met-passievrucht"
]
}
},

Copy link

sonarcloud bot commented Aug 28, 2024

@alexgarel
Copy link
Member

FYI, I added #10745

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@alexgarel alexgarel enabled auto-merge (squash) August 28, 2024 13:07
@alexgarel alexgarel merged commit e1a485e into main Aug 28, 2024
13 checks passed
@alexgarel alexgarel deleted the taxonomy-extended branch August 28, 2024 13:48
stephanegigandet pushed a commit that referenced this pull request Sep 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.44.0](v2.43.0...v2.44.0)
(2024-09-09)


### Features

* 99 French "indice de durabilité" Label images
([#10734](#10734))
([be46cf8](be46cf8))
* 99 indice de reparabilite logos
([#10748](#10748))
([e2c302b](e2c302b))
* new [taxonomy].extended.json with extended synonyms
([#10744](#10744))
([e1a485e](e1a485e))
* Open folksonomies for all connected users
([#10771](#10771))
([160b792](160b792))
* prepare folksonomy for multi-domain
([#10775](#10775))
([6f8e772](6f8e772))
* script to extract historical data for a field (e.g. Nutri-Score) for a
set of products
([#10408](#10408))
([d40bcf6](d40bcf6))


### Bug Fixes

* block more AI bots
([#10754](#10754))
([852ca5f](852ca5f))
* fix crm sync
([#10747](#10747))
([336647f](336647f))
* import_prod_data not working
([#10750](#10750))
([a895cd3](a895cd3)),
closes
[#10749](#10749)
* remove non-JS list of products
([#10743](#10743))
([6805b9f](6805b9f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate a json with extended synonym as we build taxonomies
2 participants