Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 99 French "indice de durabilité" Label images #10734

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Aug 27, 2024

What

  • feat: 99 French "indice de durabilité" Label images
  • not the most urgent - they made one SVG for every decimal of this shelved score (for now)
  • being able to display it experimentally is aspirational for the French gov and partners (HOP)

Part of

@teolemon teolemon requested a review from a team as a code owner August 27, 2024 07:40
@teolemon teolemon added the 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org label Aug 27, 2024
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you rename the files to add a dash (so that it corresponds to the label we will have), and add the size?
e.g.
indice-de-durabilite-00.svg -> indice-de-durabilite-0-0.108x90.svg

@teolemon teolemon changed the title feat: 99 IDD svg feat: 99 French "indice de durabilité" Label images Aug 28, 2024
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The height in filenames must be 90px, I renamed the files

Copy link

sonarcloud bot commented Aug 29, 2024

@stephanegigandet stephanegigandet merged commit be46cf8 into main Aug 30, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the opf-labels branch August 30, 2024 07:09
stephanegigandet pushed a commit that referenced this pull request Sep 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.44.0](v2.43.0...v2.44.0)
(2024-09-09)


### Features

* 99 French "indice de durabilité" Label images
([#10734](#10734))
([be46cf8](be46cf8))
* 99 indice de reparabilite logos
([#10748](#10748))
([e2c302b](e2c302b))
* new [taxonomy].extended.json with extended synonyms
([#10744](#10744))
([e1a485e](e1a485e))
* Open folksonomies for all connected users
([#10771](#10771))
([160b792](160b792))
* prepare folksonomy for multi-domain
([#10775](#10775))
([6f8e772](6f8e772))
* script to extract historical data for a field (e.g. Nutri-Score) for a
set of products
([#10408](#10408))
([d40bcf6](d40bcf6))


### Bug Fixes

* block more AI bots
([#10754](#10754))
([852ca5f](852ca5f))
* fix crm sync
([#10747](#10747))
([336647f](336647f))
* import_prod_data not working
([#10750](#10750))
([a895cd3](a895cd3)),
closes
[#10749](#10749)
* remove non-JS list of products
([#10743](#10743))
([6805b9f](6805b9f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labels 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants