fix: remove non-JS list of products #10743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧪 tests
Template::Toolkit
|
|
/update_tests_results |
alexgarel
approved these changes
Aug 28, 2024
Comment on lines
+5649
to
+5650
| # We indent the JSON in the generated HTML so that we can easily see diffs in integration tests outputs | ||
| $products_json = $json_indent->encode($request_ref->{structured_response}{products}); |
Comment on lines
-116
to
-127
| [% ELSE %] | ||
| <li> | ||
| [% IF product.product_name == '' %] | ||
| <a href="[% product.url %]" title="[% product.code %]"> | ||
| [% ELSE %] | ||
| <a href="[% product.url %]" title="[% product.product_name %]"> | ||
| [% END %] | ||
| <div>[% product.img %]</div> | ||
| <span>[% product.product_name %]</span> | ||
| </a> | ||
| </li> | ||
| [% END %] |
There was a problem hiding this comment.
Maybe add a message (to make it clear for people not having JS activated in some way):
[% ELSE %]
<div>Product list loading from javascript…</div>
[% END %]
stephanegigandet
pushed a commit
that referenced
this pull request
Sep 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.44.0](v2.43.0...v2.44.0) (2024-09-09) ### Features * 99 French "indice de durabilité" Label images ([#10734](#10734)) ([be46cf8](be46cf8)) * 99 indice de reparabilite logos ([#10748](#10748)) ([e2c302b](e2c302b)) * new [taxonomy].extended.json with extended synonyms ([#10744](#10744)) ([e1a485e](e1a485e)) * Open folksonomies for all connected users ([#10771](#10771)) ([160b792](160b792)) * prepare folksonomy for multi-domain ([#10775](#10775)) ([6f8e772](6f8e772)) * script to extract historical data for a field (e.g. Nutri-Score) for a set of products ([#10408](#10408)) ([d40bcf6](d40bcf6)) ### Bug Fixes * block more AI bots ([#10754](#10754)) ([852ca5f](852ca5f)) * fix crm sync ([#10747](#10747)) ([336647f](336647f)) * import_prod_data not working ([#10750](#10750)) ([a895cd3](a895cd3)), closes [#10749](#10749) * remove non-JS list of products ([#10743](#10743)) ([6805b9f](6805b9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the product opener meeting on Monday, this removes the HTML list of products that that is displayed when browsers have turned off Javascript. This is done for performance reasons, to avoid having browsers download the data twice. It also makes the responses smaller and easier to cache.