fix: update SDK contributing docs #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhamzeh
reviewed
Oct 22, 2024
|
Can you update https://github.com/openfga/sdk-generator/blob/main/config/common/files/README.mustache#L129 too please? 🙏🏽 |
rhamzeh
changed the title
rhamzeh
approved these changes
Oct 22, 2024
Remove requirement to only submit PRs to sdk-generator Update CONTRIBUTING.md.mustache Update config/common/files/CONTRIBUTING.md.mustache Co-Authored-By: Raghd Hamzeh <raghd@rhamzeh.com>
ryanpq
force-pushed
the
fix/contributing-docs-update
branch
from
09ddf6a to
df9443f
Compare
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to CONTRIBUTING.md to encourage but not require PRs be submitted against the sdk-generator repository.
References
Review Checklist
mainIf you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)