Merged
Conversation
Member
Author
|
Seems like sdk-generator doesn't fail if the tests fail. Reproduced locally, |
96338a9 to
b51370d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 122 122
Lines 9771 9771
=======================================
Hits 6759 6759
Misses 3012 3012 ☔ View full report in Codecov by Sentry. |
evansims
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Syncs changes from the generator repo and also updates some generated files that got missed
References
openfga/sdk-generator#434
openfga/sdk-generator#422
openfga/sdk-generator#424
Review Checklist
mainIf you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)