Skip to content

Conversation

@ryanpq
Copy link
Contributor

@ryanpq ryanpq commented Nov 15, 2024

Description

This PR updates with the latest on main in sdk-generator including:

  • docs: missing import in ClientCredentials example
  • fix: error correctly if apiUrl is not provided
  • [PATCH] docs:replace readable names with uuid
  • fix: update SDK contributing docs

References

openfga/sdk-generator#427
openfga/sdk-generator@9553cc3
openfga/sdk-generator@d1d472e
openfga/sdk-generator#434

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (0494769) to head (6be3050).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   87.59%   87.70%   +0.10%     
==========================================
  Files          23       23              
  Lines        1129     1139      +10     
  Branches      195      177      -18     
==========================================
+ Hits          989      999      +10     
  Misses         83       83              
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanpq ryanpq marked this pull request as ready for review November 15, 2024 17:57
@ryanpq ryanpq requested review from a team as code owners November 15, 2024 17:57
@ryanpq ryanpq force-pushed the chore/add-generator-changes branch from b81aff1 to 6be3050 Compare November 15, 2024 18:21
@ewanharris ewanharris added this pull request to the merge queue Nov 25, 2024
Merged via the queue into openfga:main with commit 84bd07f Nov 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants