Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphenate Filenames #405

Closed
wants to merge 4 commits into from
Closed

Hyphenate Filenames #405

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2019

Originally #348, by @tomschr:


Related to issue #339.

This PR contains the following changes:

  • Create filename template
  • Enable ZERO WIDTH SPACE (U+200B) in parameter ulink.hyphenate
  • Minor comment and linebreak fixes
  • Add hyphenation testcases

The result will look like this:

hyph-filename

I'm not sure if we should enable it. Please DO NOT merge it for the time being, as we should investigate it a bit further. It's just a "proof of concept" which we can play around, but I wouldn't want to see it in production code yet.

At the moment, we should keep in mind the following:

  • Our text is justified. This could lead to bigger gaps in the text if the filename cannot be broken at some characters.
  • Links should be hyphenated as well; this isn't covered in this PR (yet).
  • ATM, it seems the filenames are only broken up at the "/" (slash) character. Not sure why other characters are not taken into account.
  • We should test it with the latest FOP 2.2.

* Create filename template
* Enable ZERO WIDTH SPACE (U+200B) in ulink.hyphenate
* Minor comment and linebreak fixes
Base automatically changed from master to main February 10, 2021 11:14
@tomschr tomschr added skill-xslt XSLT knowledge necessary format-pdf pdf support labels Jul 26, 2022
@tomschr tomschr marked this pull request as draft November 17, 2022 15:27
@tomschr
Copy link
Collaborator

tomschr commented Nov 21, 2022

This is already integrated in the suse2022 stylesheets. Closing this PR.

@tomschr tomschr closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format-pdf pdf support skill-xslt XSLT knowledge necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant