Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyphenate Filenames #348

Closed
wants to merge 4 commits into from
Closed

Hyphenate Filenames #348

wants to merge 4 commits into from

Conversation

tomschr
Copy link
Collaborator

@tomschr tomschr commented Sep 27, 2017

Related to issue #339.

This PR contains the following changes:

  • Create filename template
  • Enable ZERO WIDTH SPACE (U+200B) in parameter ulink.hyphenate
  • Minor comment and linebreak fixes
  • Add hyphenation testcases

The result will look like this:

hyph-filename

I'm not sure if we should enable it. Please DO NOT merge it for the time being, as we should investigate it a bit further. It's just a "proof of concept" which we can play around, but I wouldn't want to see it in production code yet.

At the moment, we should keep in mind the following:

  • Our text is justified. This could lead to bigger gaps in the text if the filename cannot be broken at some characters.
  • Links should be hyphenated as well; this isn't covered in this PR (yet).
  • ATM, it seems the filenames are only broken up at the "/" (slash) character. Not sure why other characters are not taken into account.
  • We should test it with the latest FOP 2.2.

@tomschr
Add comment for hyphenate-url.xsl
5e8a10e
@tomschr
Hyphenate filename
749534c 
* Create filename template
* Enable ZERO WIDTH SPACE (U+200B) in ulink.hyphenate
* Minor comment and linebreak fixes
@tomschr
Add hyphenation testcases (issue #339)
40455d9
@tomschr tomschr added cat-enhancement Enhancements help wanted format-pdf pdf support styles-2013 "suse2013", "suse2013-ns", "daps2013", "daps2013-ns", "opensuse2013", "opensuse2013-ns" styles labels Sep 27, 2017
@tomschr tomschr assigned tomschr and ghost Sep 27, 2017
@tomschr tomschr requested a review from a user September 27, 2017 09:32
@ghost ghost mentioned this pull request Feb 10, 2018
Closed
@ghost ghost closed this Nov 29, 2019
@ghost ghost mentioned this pull request Nov 29, 2019
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomschr tomschr

Labels
cat-enhancement Enhancements format-pdf pdf support styles-2013 "suse2013", "suse2013-ns", "daps2013", "daps2013-ns", "opensuse2013", "opensuse2013-ns" styles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomschr