Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfortunate hyphenation of file names #339

Open
ghost opened this issue Sep 19, 2017 · 4 comments
Open

unfortunate hyphenation of file names #339

ghost opened this issue Sep 19, 2017 · 4 comments
Labels
cat-bug Malfunction, unexpected behavior cat-limbo Issues which should be investigated further format-pdf pdf support

Comments

@ghost
Copy link

ghost commented Sep 19, 2017

This might be a dupe, did not look too closely...

screenshot

(discovered by Padraig/Shane, in the SES 5 docs)

@ghost ghost changed the title unfortunate hyphenations unfortunate hyphenation of file names Sep 19, 2017
@ghost ghost added cat-bug Malfunction, unexpected behavior format-pdf pdf support labels Sep 19, 2017
@tomschr
Copy link
Collaborator

tomschr commented Sep 26, 2017

@sknorr If I remember correctly, we did that on purpose some time ago. This was not the case before. Links and filenames used the special hyphenation algorithm from suse2013/fo/hyphenate-url.xsl.

However, we did that for a reason. I think, it had something to do with ZERO WIDTH SPACE (U+200B) which FOP couldn't interpret correctly. Maybe that has changed now.

We should really package the latest FOP version soon...

@ghost
Copy link
Author

ghost commented Sep 26, 2017

Hm, I don't remember anything about FOP not rendering 0-width spaces incorrectly... Maybe this was even before my time..? (Admittedly, remembering stuff is not always my strong suit.)

@tomschr
Copy link
Collaborator

tomschr commented Sep 27, 2017

I don't remember anything about FOP not rendering 0-width spaces incorrectly... Maybe this was even before my time..?

Yes, it seems so. I've found commit 689d0e9 (Jul 4 2013!) which says:

Implemented different behaviour for XEP and FOP:
[..]
* FOP: does not recognize ZWS at all. Therefor, hyphenation is *enabled*
  and the hyphenation algorithm is NOT used. Furthermore, parameter
  ulink.properties is set to hyphenate=true, hyphenate-character=​
  This does not look really nice, but it gives at least some help.

Not sure about the FOP version, but it could be 1.0.

tomschr added a commit that referenced this issue Sep 27, 2017
ghost pushed a commit that referenced this issue Nov 29, 2019
@ghost ghost mentioned this issue Nov 29, 2019
@janajaeger janajaeger added the cat-limbo Issues which should be investigated further label Jul 20, 2022
@tomschr
Copy link
Collaborator

tomschr commented Nov 21, 2022

This is still valid, but a systemic issue. If we enable the hyphenation algorithm in filenames and URLs, it will search for possible hyphenation spots (slashes, underscores, ampersands, etc.). However, very long filenames which consists of only characters cannot are not hyphenated correctly. In such a case, the writers has to do add the ZERO WIDTH SPACE manually. Or we don't hyphenate---with the above result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat-bug Malfunction, unexpected behavior cat-limbo Issues which should be investigated further format-pdf pdf support
Projects
None yet
Development

No branches or pull requests

2 participants