ParticleSpecies: Read to pandas.DataFrame #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Feb 5, 2021
ax3l
force-pushed
the
topic-pandas
branch
5 times, most recently
from
04928c6 to
1a6bb81
Compare
ax3l
changed the title
ax3l
changed the title
ax3l
commented
Feb 5, 2021
| found_pandas = False | ||
|
|
||
|
|
||
| def particles_to_dataframe(particle_species, slice=None): |
There was a problem hiding this comment.
Potential extra arguments:
records = iterable: a list of strings or regex expressions to load only specific records of the species- maybe an inverse parameter to deselect specific records from loading
ax3l
commented
Feb 5, 2021
dmitry-ganyushin
approved these changes
Feb 5, 2021
| particle_species.series_flush() | ||
| columns[column_name] *= rc.unit_SI | ||
|
|
||
| return pd.DataFrame(columns) |
There was a problem hiding this comment.
How large are particle species data? It looks like panda lib has capability to work with tables not fitting into memory.
There was a problem hiding this comment.
Particle data can be anything between 0 and 1e13 as of today.
Can you point me to information on how to handle out-of-core data in pandas?
ax3l
force-pushed
the
topic-pandas
branch
2 times, most recently
from
1f3ce13 to
32c0cba
Compare
This comment has been minimized.
This comment has been minimized.
ax3l
changed the title
|
This pull request introduces 1 alert when merging 98ce484 into d97adf8 - view on LGTM.com new alerts:
|
ax3l
commented
Feb 11, 2021
Add a method tha reads a particle species into a `pandas.DataFrame`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method tha reads a particle species into a
pandas.DataFrame.To Do