Package & Module: amrex #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the package and import module to `amrex`. Rename the internal C++-generated module to `amrex_pybind`. Note: Users interface with the `amrex` module and its (future) sub-modules. We wrap all pybind-generated modules in another, fluffy Python module so pyAMReX developers can expand them in pure Python if they feel like it.
ax3l
force-pushed
the
topic-importAmrex
branch
from
84a93a7 to
b9ee2a6
Compare
sayerhs
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the package and import module to
amrex.Rename the internal C++-generated module to
amrex_pybind.Note: Users interface with the
amrexmodule and its (future) sub-modules. We wrap all pybind-generated modules in another, fluffy Python module so pyAMReX developers can expand them in pure Python if they feel like it.An example of such an extension can be seen here: openPMD/openPMD-api#923