Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame: Fix unitSI #956

Merged
merged 1 commit into from
Apr 6, 2021
Merged

DataFrame: Fix unitSI #956

merged 1 commit into from
Apr 6, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 6, 2021

  • convert only when needed
  • fix type mismatch, e.g. for particle id

Follow-up to #923

- convert only when needed
- fix type mismatch, e.g. for particle `id`
@ax3l ax3l force-pushed the fix-dataframeUnitSI branch from 93a68fe to 475d373 Compare April 6, 2021 06:02
@ax3l ax3l merged commit 4a25b1a into openPMD:dev Apr 6, 2021
@ax3l ax3l deleted the fix-dataframeUnitSI branch April 6, 2021 07:01
@ax3l ax3l requested a review from dmitry-ganyushin April 8, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant