WEB-489: Add missing translation keys for route titles#2936
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Bulk translation additions & minor wording fixes src/assets/translations/{cs-CS,de-DE,en-US,es-CL,es-MX,fr-FR,it-IT,ko-KO,lt-LT,lv-LV,ne-NE,pt-PT,sw-SW}.json |
Added keys: Cashiers, Collection Sheet, Loans Deferred Income, Shares Account General, View Cashier across listed locales. Mostly additive inserts. Notable wording changes: Czech (cs-CS) adjusted "View Cashiers" → singular; German (de-DE), Spanish (Mexico es-MX), and Latvian (lv-LV) updated existing "Collection Sheet" wording in some sections. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
- WEB-481 :- a translation problem in mifos home page Tooltip text shows tooltips.Collection Sheet instead of Collection Sheet #2863: related to "Collection Sheet" translation key usage and tooltip fixes.
- WEB-468 Incorrect label displayed as label input saving product on create saving product page #2895: overlaps edits to
cs-CS.jsonand translation key restructuring. - Cherry-pick
dev-angular-19changes back todev#2865: adjusts Collection Sheet tooltip key tolabels.menus.Collection Sheet, directly related to these keys.
Suggested reviewers
- IOhacker
- alberto-art3ch
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly summarizes the main change: adding missing translation keys for route titles to fix display issues where raw keys were shown instead of translations. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
src/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
🚧 Files skipped from review as they are similar to previous changes (11)
- src/assets/translations/ne-NE.json
- src/assets/translations/it-IT.json
- src/assets/translations/pt-PT.json
- src/assets/translations/cs-CS.json
- src/assets/translations/lt-LT.json
- src/assets/translations/en-US.json
- src/assets/translations/de-DE.json
- src/assets/translations/ko-KO.json
- src/assets/translations/sw-SW.json
- src/assets/translations/es-MX.json
- src/assets/translations/es-CL.json
🔇 Additional comments (2)
src/assets/translations/lv-LV.json (1)
357-357: LGTM! Previous translation issues have been resolved.The changes successfully address all three issues flagged in previous reviews:
- Collection Sheet terminology - Now consistently uses "Iekasēšanas Lapa" across all instances (lines 357, 2564, 2635, 2864)
- Shares Account General grammar - "Akciju konta Vispārīgi" (line 3288) is now grammatically consistent with "Akciju konts" (line 2610), using the correct genitive case
- Cashier capitalization - Both "View Cashiers" (line 529) and "View Cashier" (line 3352) now consistently use "Skatīt Kasieri" with uppercase 'K'
The newly added translations for "Cashiers" (line 2835) and "Loans Deferred Income" (line 3130) are also consistent with the existing terminology and grammatically correct.
Also applies to: 529-529, 2564-2564, 2610-2610, 2635-2635, 2835-2835, 2864-2864, 3130-3130, 3288-3288, 3352-3352
src/assets/translations/fr-FR.json (1)
2835-2835: New route-related translations look correct; consider minor consistency tweaks.The added keys align with the PR goal and are all understandable in French. A few optional consistency nits with existing strings:
- Line 2864: Other sections already use « Feuille de collecte » for “Collection Sheet”; consider matching that here.
- Line 3351: You use « Afficher le caissier » while the plural “View Cashiers” button is « Voir les caissiers ». Aligning on one verb (e.g. “Voir”) would be cleaner.
- Line 3287: « Compte d'actions Général » is fine, but French style would usually lowercase the adjective: « Compte d'actions général ». Not blocking, just a style nit.
[ suggest_optional_refactor ]
Example diff for consistency (optional)
@@ - "Collection Sheet": "Fiche de collecte", + "Collection Sheet": "Feuille de collecte", @@ - "Shares Account General": "Compte d'actions Général", + "Shares Account General": "Compte d'actions général", @@ - "View Cashier": "Afficher le caissier", + "View Cashier": "Voir le caissier",Also applies to: 2864-2864, 3130-3130, 3287-3287, 3351-3351
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🧹 Nitpick comments (6)
src/assets/translations/fr-FR.json (3)
2864-2864: Verify translation consistency with existing key.The translation "Fiche de collecte" differs from the existing translation on Line 357 which uses "Feuille de collecte" for the same English term "Collection Sheet." While both are valid French translations, having different translations for the same English term may cause confusion.
- Line 357 (buttons section): "Feuille de collecte" (literally "sheet")
- Line 2864 (text section): "Fiche de collecte" (form/card)
Consider using consistent terminology throughout the application unless the context genuinely requires different translations.
3287-3287: Consider lowercase for "général" per French grammar conventions.In French, adjectives are typically lowercase unless they are proper nouns or at the start of a sentence. The translation "Compte d'actions Général" should likely be "Compte d'actions général" to follow standard French grammar rules, unless "Général" is part of a specific proper noun or official account type name.
3351-3351: Inconsistent verb choice for "View" translations.Line 3351 uses "Afficher" (to display) while Line 529 uses "Voir" (to view/see) for similar "View Cashier(s)" translations:
- Line 529: "View Cashiers": "Voir les caissiers"
- Line 3351: "View Cashier": "Afficher le caissier"
While both verbs are correct, consider using "Voir le caissier" for consistency with the existing plural form. Note that this inconsistency exists throughout the codebase for various "View X" patterns, so a broader standardization effort may be warranted.
src/assets/translations/pt-PT.json (2)
2864-2864: Consider standardizing capitalization for "Collection Sheet" across all sections.The translation "Folha de coleta" (lowercase 'c') is used here and in the menus section (line 2635), but the buttons section (line 357) uses "Folha de Coleta" (capital 'C'). For consistency and standard Portuguese grammar (where common nouns mid-phrase are typically lowercase), consider updating line 357 to match this lowercase style.
3288-3288: Consider using lowercase "geral" for standard Portuguese style.While the translation works, Portuguese grammar conventions typically use lowercase for descriptive adjectives like "geral" unless they're part of a proper noun. Consider: "Conta de ações geral" instead of "Conta de ações Geral".
src/assets/translations/lv-LV.json (1)
3288-3288: Translation follows existing pattern, consider terminology consistency review.The translation "Kopīgo konta Vispārīgi" follows the pattern used in lines 3286-3287 for "Shares Account" related terms. However, there's an inconsistency in the file where line 3176 translates "Shares Account" as "Akciju konts" (stocks account) while lines 3286-3288 use "Kopīgo konta" (shared account).
Optional improvement: Consider standardizing the translation of "Shares Account" terminology across the file to use either:
- "Akciju konts" (if referring to financial shares/stocks), or
- "Kopīgo konta" (if referring to shared accounts)
This is a pre-existing consistency issue in the codebase, not introduced by this PR.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
src/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
🔇 Additional comments (28)
src/assets/translations/lt-LT.json (1)
2864-2864: Translations look correct.The new translation entries for "Collection Sheet" and "Loans Deferred Income" are grammatically correct and consistent with existing translations in the file.
Also applies to: 3130-3130
src/assets/translations/fr-FR.json (2)
2835-2835: Translation looks correct.The French translation "Caissiers" is appropriate for "Cashiers."
3129-3129: Translation is accurate.The French translation "Revenus différés des prêts" correctly translates "Loans Deferred Income" and follows proper French grammar conventions.
src/assets/translations/en-US.json (1)
2844-2844: LGTM! Translation keys added correctly.All five translation keys have been properly added across all 13 locale files to fix the route title display issue. The additions follow the existing structure and naming conventions.
The keys are appropriately placed in the
labels.textsection and will resolve the raw translation key display mentioned in the PR (e.g., "labels.text.Collection Sheet" → "Collection Sheet").Verified:
- All 5 keys present in all 13 locale files
- All locale files have valid JSON syntax
- Keys properly positioned and formatted
src/assets/translations/sw-SW.json (4)
2833-2833: Verify consistency of "Cashiers" translation.The translation "Wakasisi" for "Cashiers" appears inconsistent with the existing translation "Keshia" for "Cashier" (line 1402). While "Wakasisi" may be a valid plural form, the singular-plural relationship between "Keshia" and "Wakasisi" is not immediately clear and could cause confusion.
Please verify:
- Is "Wakasisi" the correct plural form of "Keshia"?
- Should there be consistency in the root word used across singular/plural forms?
Consider consulting with a Swahili speaker to confirm the appropriate terminology for consistency across the application.
2862-2862: LGTM - Consistent translation.The translation "Karatasi ya Mkusanyiko" for "Collection Sheet" is consistent with existing translations in the file (lines 357, 2634). This correctly addresses the missing translation key mentioned in the PR objectives.
3127-3127: Translation appears well-formed.The translation "Mapato yaliyohimiliwa ya Mikopo" for "Loans Deferred Income" follows the grammatical structure of other compound phrases in the file and addresses the missing translation key.
3285-3285: LGTM - Consistent with existing pattern.The translation "Akaunti ya Hisa Jumla" for "Shares Account General" correctly extends the existing "Akaunti ya Hisa" pattern with "Jumla" (General), maintaining consistency with the file's translation approach.
src/assets/translations/de-DE.json (2)
3287-3287: LGTM! Translation is appropriateThe translation "Aktienkonto Allgemein" correctly conveys "Shares Account General" using proper German financial terminology.
2835-2835: LGTM! Cashier translations are correct and consistentBoth translations are accurate:
- Line 2835: "Cashiers" → "Kassierer" ✓
- Line 3351: "View Cashier" → "Kassierer anzeigen" ✓
These are consistent with existing translations in the file (e.g., line 529 "View Cashiers": "Kassierer anzeigen").
Also applies to: 3351-3351
src/assets/translations/ne-NE.json (1)
2833-2833: LGTM! Translation additions are correct and well-placed.The five new Nepali translation entries have been added correctly:
- "Cashiers", "Collection Sheet" in the
textsection- "Loans Deferred Income", "Shares Account General", "View Cashier" in the
headingsectionThe translations are semantically accurate and consistent with existing patterns in the file (e.g., "View Cashier" vs "View Cashiers" properly handling singular/plural forms). These additions will resolve the issue where raw translation keys were being displayed instead of translated text.
Also applies to: 2862-2862, 3127-3127, 3285-3285, 3349-3349
src/assets/translations/pt-PT.json (3)
2835-2835: LGTM! Consistent translation added.The translation "Cashiers": "Caixas" is consistent with the existing singular form "Cashier": "Caixa" (line 1404) and follows proper Portuguese pluralization.
3130-3130: LGTM! Appropriate translation for loans context.The translation "Renda diferida de empréstimos" correctly extends the base translation "Renda diferida" (line 1579) with the loans context, following proper Portuguese grammar.
3352-3352: LGTM! Consistent with existing translations.The translation "Ver caixa" is consistent with "View Cashiers": "Ver caixas" (line 529) and follows the established pattern for "View" translations in the file.
src/assets/translations/it-IT.json (1)
357-357: LGTM! Translation additions are consistent and appropriate.The Italian translations for the five new keys (Cashiers, Collection Sheet, Loans Deferred Income, Shares Account General, View Cashier) are grammatically correct and follow the existing patterns in the file:
- Proper use of singular vs. plural forms with appropriate articles
- Consistent with the "View" translation pattern used elsewhere
- Appropriate financial/banking terminology
- Correct Italian capitalization rules
These additions should resolve the issue where raw translation keys were being displayed instead of translated text.
Also applies to: 529-529, 2835-2835, 2864-2864, 3130-3130, 3288-3288, 3352-3352
src/assets/translations/cs-CS.json (2)
2863-2863: Translation is correct and consistentThe translation "Sbírkový list" matches the existing translation at line 357, maintaining consistency across the file.
3128-3128: Translation is grammatically correctThe translation "Odložený příjem z úvěrů" follows proper Czech grammar with correct adjective-noun agreement and prepositional phrase structure.
src/assets/translations/lv-LV.json (4)
2835-2835: LGTM! Translation for "Cashiers" added correctly.The translation "Kasieri" is appropriately placed in the
labels.catalogssection and is consistent with the singular form "Skatīt kasieri" used elsewhere in the file.
2864-2864: LGTM! Translation for "Collection Sheet" added correctly.The translation "Kolekcijas lapa" is appropriately placed in the
labels.catalogssection.
3130-3130: LGTM! Translation for "Loans Deferred Income" added correctly.The translation "Kredītu atliktie ienākumi" is appropriately placed in the
labels.headingsection.
3352-3352: LGTM! Translation for "View Cashier" added correctly.The translation "Skatīt kasieri" is appropriately placed in the
labels.menussection and is consistent with the plural form "Kasieri" at line 2835.src/assets/translations/es-CL.json (2)
2865-2865: Consider standardizing "Collection Sheet" translation terminology across the file.The key "Collection Sheet" at line 2865 is translated as "Hoja de colección," but other sections of the same file use different translations for similar terms:
- Line 357: "Collection Sheet" → "Hoja de recuperación"
- Line 564: "collection_sheet" → "Hoja de Cobranza"
- Line 2636: "Collection Sheet" → "Hoja de colección" (matches this entry)
Verify whether these variations are intentional (different contexts requiring different terminology) or if they should be standardized for consistency. If this is an intentional distinction (e.g., different UI contexts), consider documenting why or ensuring the most appropriate term is used throughout.
2836-2836: New translation keys are properly integrated and grammatically correct.The four remaining newly added translation keys are well-translated and consistently formatted:
- "Cashiers" → "Cajeros" (Line 2836) — properly uses plural form
- "Loans Deferred Income" → "Ingresos diferidos de préstamos" (Line 3131) — accurate and natural Spanish word order
- "Shares Account General" → "Cuenta de acciones General" (Line 3289) — correctly preserves capitalization of "General"
- "View Cashier" → "Ver cajero" (Line 3353) — appropriately uses singular form
All entries follow the established formatting conventions and maintain consistency with related translations in the file.
Also applies to: 3131-3131, 3289-3289, 3353-3353
src/assets/translations/ko-KO.json (1)
2835-2835: LGTM! New translation entries added correctly.The five new translation keys have been added appropriately:
- "Cashiers": "계산원"
- "Collection Sheet": "수집 시트"
- "Loans Deferred Income": "대출 이연 소득"
- "Shares Account General": "주식 계정 일반"
- "View Cashier": "계산원 보기"
The translations follow existing patterns and are placed in the correct sections of the JSON structure. The "View Cashier" entry correctly reuses the "계산원" term from the "Cashiers" entry, maintaining consistency.
However, consider having these translations reviewed by a native Korean speaker or localization expert to ensure:
- Banking/financial terminology uses the most appropriate and commonly understood Korean terms
- Cultural appropriateness for the Korean market
- Consistency with industry-standard Korean banking terminology
Based on the PR objectives, these additions should resolve the issue where route titles were displaying raw translation keys like "labels.text.Collection Sheet" instead of translated text.
Also applies to: 2864-2864, 3130-3130, 3288-3288, 3352-3352
src/assets/translations/es-MX.json (4)
2837-2837: LGTM! Translation is accurate.The translation "Cashiers" → "Cajeros" is correct and follows proper Spanish grammar for plural nouns.
3132-3132: LGTM! Financial terminology is accurate.The translation "Loans Deferred Income" → "Ingresos diferidos de préstamos" uses correct accounting terminology and is consistent with other loan-related translations in the file.
3290-3290: LGTM! Translation is correct.The translation "Shares Account General" → "Cuenta de acciones General" is accurate. The capitalization of "General" appears intentional, likely indicating a section or tab name, which is appropriate.
3354-3354: LGTM! Translation follows established patterns.The translation "View Cashier" → "Ver cajero" is correct and consistent with:
- The "View X" → "Ver X" pattern used throughout the file
- Line 2837 where "Cashiers" is translated as "Cajeros"
shubhamkumar9199
force-pushed
the
fix/WEB-489-route-title-translations
branch
from
c70ed92 to
4c7d32b
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/assets/translations/es-MX.json (1)
564-565: Remaining "Collection Sheet" translation inconsistency.While line 2867 was updated to use "Hoja de recuperación", lines 564-565 in the catalogs section still use "Hoja de Cobranza". For complete consistency across the application, this should also be changed to "Hoja de recuperación" to match:
- Line 357 (buttons): "Hoja de recuperación"
- Line 2637 (menus): "Hoja de recuperación"
- Line 2867 (menus): "Hoja de recuperación"
- Lines 2658, 3084 (Individual Collection Sheet): "Hoja de recuperación individual"
🔎 Suggested fix
- "Collection_sheet": "Hoja de Cobranza", - "collection_sheet": "Hoja de Cobranza", + "Collection_sheet": "Hoja de recuperación", + "collection_sheet": "Hoja de recuperación",Based on past review comments, this inconsistency was previously identified and partially addressed in this PR.
♻️ Duplicate comments (1)
src/assets/translations/es-MX.json (1)
2867-2867: Good progress on consistency, but incomplete.The translation has been correctly updated from "Hoja de colección" to "Hoja de recuperación", addressing part of the previous review feedback. However, lines 564-565 still use "Hoja de Cobranza" and should be updated as well for complete consistency.
Based on past review comments, this addresses the concern raised for this specific line, though the overall consistency issue remains at lines 564-565.
🧹 Nitpick comments (3)
src/assets/translations/lt-LT.json (1)
3288-3288: Unnatural word order in Lithuanian.The translation "Akcijų sąskaita Bendroji" has an awkward word order. In Lithuanian, adjectives typically precede nouns, or when following, should be lowercase and agree with the noun's gender and case.
🔎 Suggested alternatives
- "Shares Account General": "Akcijų sąskaita Bendroji", + "Shares Account General": "Bendroji akcijų sąskaita",Or alternatively with lowercase:
- "Shares Account General": "Akcijų sąskaita Bendroji", + "Shares Account General": "Akcijų sąskaita bendra",Based on learnings, the previous review suggested similar reordering for more natural Lithuanian phrasing.
src/assets/translations/ko-KO.json (1)
2864-2864: Consider more contextually specific translation for "Collection Sheet"The current translation "수집 시트" is literally correct, but in a financial/microfinance context, "수금 시트" (receipt/collection sheet) might be more contextually appropriate as it specifically relates to collecting payments.
Current:
"Collection Sheet": "수집 시트"
Suggestion:"Collection Sheet": "수금 시트"This is an optional refinement to improve contextual accuracy.
src/assets/translations/es-MX.json (1)
3290-3290: Capitalize "General" according to Spanish grammar conventions.In Spanish, adjectives like "general" are typically lowercase unless they start a sentence or are part of a proper noun. The current capitalization doesn't follow standard Spanish grammar rules.
🔎 Suggested fix
- "Shares Account General": "Cuenta de acciones General", + "Shares Account General": "Cuenta de acciones general",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
src/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
🚧 Files skipped from review as they are similar to previous changes (8)
- src/assets/translations/it-IT.json
- src/assets/translations/ne-NE.json
- src/assets/translations/cs-CS.json
- src/assets/translations/pt-PT.json
- src/assets/translations/es-CL.json
- src/assets/translations/sw-SW.json
- src/assets/translations/de-DE.json
- src/assets/translations/fr-FR.json
🔇 Additional comments (8)
src/assets/translations/en-US.json (1)
2844-2844: LGTM! Translation keys correctly added to fix raw key display issues.All five translation keys have been properly added to the
labels.textsection:
- "Cashiers" (line 2844)
- "Collection Sheet" (line 2873)
- "Loans Deferred Income" (line 3223)
- "Shares Account General" (line 3393)
- "View Cashier" (line 3458)
The additions are syntactically correct, properly formatted, and appropriately placed within the JSON structure. All keys are present across all 13 locale files (cs-CS, de-DE, en-US, es-CL, es-MX, fr-FR, it-IT, ko-KO, lt-LT, lv-LV, ne-NE, pt-PT, sw-SW) with consistent formatting. The keys are actively used in routing configurations where they appear as route titles and breadcrumbs, confirming they fix the issue where these labels were previously displayed as raw translation keys.
Also applies to: 2873-2873, 3223-3223, 3393-3393, 3458-3458
src/assets/translations/lt-LT.json (1)
2864-2864: LGTM!These translations are grammatically correct and contextually appropriate for Lithuanian.
Also applies to: 3130-3130
src/assets/translations/lv-LV.json (1)
2835-2835: LGTM!The translations for "Cashiers" and "Loans Deferred Income" are grammatically correct and consistent with related translations in the file:
- "Cashiers": "Kasieri" correctly uses the plural form (cf. singular "Kasieris" at line 2404)
- "Loans Deferred Income": "Kredītu atliktie ienākumi" is grammatically correct and consistent with "Deferred income": "Atliktie ienākumi" at line 1579
Also applies to: 3130-3130
src/assets/translations/ko-KO.json (1)
2835-2835: LGTM! Translation additions are accurate and consistentThe added translation keys are:
- "Cashiers": "계산원" - Correctly translates to cashiers/tellers
- "Loans Deferred Income": "대출 이연 소득" - Appropriate financial accounting term
- "Shares Account General": "주식 계정 일반" - Accurate for general shares account section
- "View Cashier": "계산원 보기" - Consistent with existing "View X" patterns
All translations follow proper Korean grammar and are contextually appropriate for the financial services domain. The additions successfully address the issue of missing route title translations as described in the PR objectives.
Also applies to: 3130-3130, 3288-3288, 3352-3352
src/assets/translations/es-MX.json (4)
2637-2637: LGTM! Translation is consistent.The "Collection Sheet" translation "Hoja de recuperación" aligns with the recommended terminology used elsewhere in the application.
2838-2838: LGTM! New "Cashiers" translation is appropriate.The translation "Cajeros" is grammatically correct and consistent with the related translation at line 3354 ("View Cashier": "Ver cajero").
3132-3132: LGTM! Accounting terminology is accurate.The translation "Ingresos diferidos de préstamos" correctly uses standard Spanish accounting terminology for deferred income related to loans.
3354-3354: LGTM! Translation is consistent and correct.The translation "Ver cajero" is grammatically correct and consistent with the related "Cashiers" translation at line 2838.
fix translation issues Fixed translation issues across multiple languages
shubhamkumar9199
force-pushed
the
fix/WEB-489-route-title-translations
branch
from
4c7d32b to
16be84a
Compare
2 participants
This PR fixes an issue where some route titles and breadcrumbs were displaying raw translation keys (for example, labels.text.Collection Sheet,labels.text.Cashiers) instead of translated text.
WEB-489
Before:
After:
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit
New Features
Bug Fixes / Updates
✏️ Tip: You can customize this high-level summary in your review settings.