Skip to content

WEB-481 :- a translation problem in mifos home page Tooltip text shows tooltips.Collection Sheet instead of Collection Sheet#2863

Merged
gkbishnoi07 merged 1 commit intoopenMF:dev-angular-19from
Omar-Nabil2:CollectionSheet
Dec 7, 2025
Merged

WEB-481 :- a translation problem in mifos home page Tooltip text shows tooltips.Collection Sheet instead of Collection Sheet#2863
gkbishnoi07 merged 1 commit intoopenMF:dev-angular-19from
Omar-Nabil2:CollectionSheet

Conversation

@Omar-Nabil2
Copy link
Contributor

@Omar-Nabil2 Omar-Nabil2 commented Dec 7, 2025

Description

a translation problem in mifos home page Tooltip text shows tooltips.Collection Sheet instead of Collection Sheet

image image

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • Chores
    • Updated localization references for menu item tooltips to align with current naming conventions in the translation system. No visible changes to user functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

…Collection Sheet instead of Collection Sheet
@coderabbitai
Copy link

coderabbitai bot commented Dec 7, 2025

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Updated the translation key for the Collection Sheet menu item's tooltip in the sidenav component from tooltips.Collection Sheet to labels.menus.Collection Sheet. This is a localization key reference change with no functional logic modifications.

Changes

Cohort / File(s) Summary
Translation key update
src/app/core/shell/sidenav/sidenav.component.html
Updated tooltip translation key from tooltips.Collection Sheet to labels.menus.Collection Sheet for the Collection Sheet menu item

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the specific issue (translation problem with tooltip text showing a translation key instead of the actual translated text) and directly corresponds to the change made in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6499094 and b1adc79.

📒 Files selected for processing (1)
  • src/app/core/shell/sidenav/sidenav.component.html (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/app/**

⚙️ CodeRabbit configuration file

src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.

Files:

  • src/app/core/shell/sidenav/sidenav.component.html
🔇 Additional comments (1)
src/app/core/shell/sidenav/sidenav.component.html (1)

97-108: Pattern inconsistency: Collection Sheet tooltip now uses labels.menus while all other tooltips use tooltips prefix.

The tooltip translation key has been changed to labels.menus.Collection Sheet (line 100), fixing the missing translation issue. However, this breaks the established naming convention—all other menu item tooltips use the tooltips.* namespace (Dashboard, Navigation, Checker Inbox, etc. on lines 64, 76, 88, etc.), while labels use labels.menus.*. Note that "Individual Collection Sheet" on line 112 still follows the tooltips.* pattern, creating an inconsistency within related menu items.

Verify that the translation file has the key labels.menus.Collection Sheet present (not tooltips.Collection Sheet), and consider whether other tooltips should be aligned to the same pattern for consistency.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gkbishnoi07 gkbishnoi07 merged commit 7749221 into openMF:dev-angular-19 Dec 7, 2025
3 checks passed
@Omar-Nabil2 Omar-Nabil2 deleted the CollectionSheet branch December 8, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants