WEB-481 :- a translation problem in mifos home page Tooltip text shows tooltips.Collection Sheet instead of Collection Sheet#2863
Conversation
…Collection Sheet instead of Collection Sheet
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Translation key update src/app/core/shell/sidenav/sidenav.component.html |
Updated tooltip translation key from tooltips.Collection Sheet to labels.menus.Collection Sheet for the Collection Sheet menu item |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly identifies the specific issue (translation problem with tooltip text showing a translation key instead of the actual translated text) and directly corresponds to the change made in the PR. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/app/core/shell/sidenav/sidenav.component.html(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/app/**
⚙️ CodeRabbit configuration file
src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.
Files:
src/app/core/shell/sidenav/sidenav.component.html
🔇 Additional comments (1)
src/app/core/shell/sidenav/sidenav.component.html (1)
97-108: Pattern inconsistency: Collection Sheet tooltip now useslabels.menuswhile all other tooltips usetooltipsprefix.The tooltip translation key has been changed to
labels.menus.Collection Sheet(line 100), fixing the missing translation issue. However, this breaks the established naming convention—all other menu item tooltips use thetooltips.*namespace (Dashboard, Navigation, Checker Inbox, etc. on lines 64, 76, 88, etc.), while labels uselabels.menus.*. Note that "Individual Collection Sheet" on line 112 still follows thetooltips.*pattern, creating an inconsistency within related menu items.Verify that the translation file has the key
labels.menus.Collection Sheetpresent (nottooltips.Collection Sheet), and consider whether other tooltips should be aligned to the same pattern for consistency.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Description
a translation problem in mifos home page Tooltip text shows tooltips.Collection Sheet instead of Collection Sheet
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.