This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Fix SDP failure if hardware acceleration is not turned on #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taste1981
force-pushed
the
sdp_failure
branch
from
3319deb to
562ef0a
Compare
jianjunz
reviewed
Sep 11, 2019
| @@ -126,6 +128,13 @@ void PeerConnectionDependencyFactory:: | |||
| if (!GlobalConfiguration::GetCustomizedVideoDecoderEnabled()) { | |||
| decoder_factory.reset(new MSDKVideoDecoderFactory()); | |||
| } | |||
| } else { | |||
| if (!encoded_frame_) { | |||
There was a problem hiding this comment.
It's paired with line 144?
There was a problem hiding this comment.
paired with line 124.
| if (!encoded_frame_) { | ||
| encoder_factory = std::move(webrtc::CreateBuiltinVideoEncoderFactory()); | ||
| } | ||
| if (!GlobalConfiguration::GetCustomizedVideoDecoderEnabled()) { |
There was a problem hiding this comment.
refactored the code to be more reasonable here.
taste1981
commented
Sep 11, 2019
| if (!encoded_frame_) { | ||
| encoder_factory = std::move(webrtc::CreateBuiltinVideoEncoderFactory()); | ||
| } | ||
| if (!GlobalConfiguration::GetCustomizedVideoDecoderEnabled()) { |
There was a problem hiding this comment.
this adds handling when hardware_acceleration is not true. not related with line 142.
There was a problem hiding this comment.
Refactored the code here to be more reasonable.
taste1981
force-pushed
the
sdp_failure
branch
from
562ef0a to
4cf9b3d
Compare
jianjunz
approved these changes
Sep 12, 2019
taste1981
pushed a commit
that referenced
this pull request
Oct 8, 2019
* Build OWT with libwebrtc M76. (#143) * Update DEPS for WebRTC M76. * Build OWT with libwebrtc M76. Most custom features are disabled. It will be re-enabled in C++ SDK in following PRs. Custom audio/video input/output may be removed from Android and iOS SDK. Recommended way to use these kinds of features on Android and iOS is implementing your own video source, encoder, decoder by inheriting WebRTC classes. OWT will provide some APIs to work with custom WebRTC components. An example of these APIs would be `initWithMediaStream:(RTCMediaStream*)mediaStream source: (OWTStreamSourceInfo*)source`. As the RTCMediaStream is created by app, it has more control on the stream created, e.g.: switching media source during the call. * Enable windows SDK build on M76 (#158) * Enable customized input and local camera input (#159) * Enable windows SDK build on M76 * Disable rtc_use_h264 so that to avoid ffmpeg build. - enumerate supported h264 profiles explicitly. - seperate camera capture source from webrtc stack - update gn args for build-win.py to not use clang for build. - update gn args to set rtc_use_h264 to false * Fix encoded h.264 publish issue (#160) * Enable windows SDK build on M76 * Disable rtc_use_h264 so that to avoid ffmpeg build. - enumerate supported h264 profiles explicitly. - seperate camera capture source from webrtc stack - update gn args for build-win.py to not use clang for build. - update gn args to set rtc_use_h264 to false * Fix encoded h264 publish issue * Enable building with rtc_use_h265 set to true (#161) Enable build with rtc_use_h265 enabled * Remove taskqueuefactory from p2p client header file (#162) Remove taskqueuefactory from p2pclient header * Fix issue #165: SDK crashes on failed local stream creation. (#166) Also updated DEPS to use latest 76-sdk. * Simulcast suppoort for Windows. Also enable build with openssl. (#168) * Add AudioPlayerInterface for Windows SDK (#169) * Correct the path for two Objective-C headers. (#170) * Issue 43: publish without options crashes (#173) * Set transceiver's stream_ids. (#175) If this member is not set, remote side will not associate track to stream. * Fix pub failure when audio is present * Add enable_iterator_debugging flag for debug mode to fix debug application link error. (#176) * Fix issue #177: windows client crash of destruction of video stream (#184) * Fix undefined symbols error for iOS. (#174) Some features are only available on Windows and Linux. * Fix SDP failure if hardware acceleration is not turned on (#183) * Remove owt_rebase_m63 flag. (#191) * Fix BDBA issue on libjpeg_turbo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.