Skip to content

Stabilize network.transport enum value quic #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Stabilize network.transport enum value quic #2275

merged 1 commit into from
May 16, 2025

Conversation

@trask
Copy link
Member

@trask trask commented May 15, 2025

This unstable enum value was accidentally marked stable in (probably many) implementations, e.g.: open-telemetry/semantic-conventions-java#220 (review)

We are addressing the code gen issue going forward, but quic was the only prior problematic case, and probably makes sense to stabilize quic anyways since it's a legit network protocol: https://datatracker.ietf.org/doc/html/rfc9000

@trask trask requested review from a team as code owners May 15, 2025 22:10
@github-actions github-actions bot added enhancement New feature or request area:network labels May 15, 2025
@trask trask force-pushed the stabilize-quic branch from c500cb3 to cdb620b Compare May 15, 2025 22:11
@trentm trentm mentioned this pull request May 15, 2025
Merged
@trask trask mentioned this pull request May 15, 2025
Closed
@github-project-automation github-project-automation bot moved this from Untriaged to Needs More Approval in Semantic Conventions Triage May 15, 2025
@joaopgrassi joaopgrassi moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage May 16, 2025
@github-project-automation github-project-automation bot moved this from Ready to be Merged to Needs More Approval in Semantic Conventions Triage May 16, 2025
@trask trask added this pull request to the merge queue May 16, 2025
Merged via the queue into open-telemetry:main with commit 607a441 May 16, 2025
14 checks passed
@trask trask deleted the stabilize-quic branch May 16, 2025 15:35
trentm added a commit to trentm/opentelemetry-js that referenced this pull request May 16, 2025
@trentm
grandfather NETWORK_TRANSPORT_VALUE_QUIC as stable
cfe1411 
In the coming v1.34.0 semconv release it will be stable.
open-telemetry/semantic-conventions#2275
@lmolkova lmolkova mentioned this pull request May 16, 2025
Merged
@MrAlias MrAlias mentioned this pull request May 22, 2025
Merged
MrAlias added a commit to open-telemetry/opentelemetry-go that referenced this pull request May 23, 2025
@MrAlias
Semconv v1.34.0 (#6812)
e587b18 
Resolve #6811 
Resolve #6691

No migration documentation is added. This does not contain any breaking
changes between v1.34.0 and v1.33.0 for the Go API.

## [`v1.34.0` semantic convention release
notes](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.34.0):

<h3>🛑 Breaking changes 🛑</h3>
<ul>
<li>
<p><code>all</code>: Convert deprecated text to structured format. (<a
href="open-telemetry/semantic-conventions#2047"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2047/hovercard">#2047</a>)<br>
This is a breaking change from the schema perspective, but does not
change anything for instrumentations or the end users. It breaks
compatibility with the (old) <a
href="open-telemetry/build-tools#322"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/build-tools/issues/322/hovercard">code
generation tooling</a>. Please use <a
href="https://github.com/open-telemetry/weaver">weaver</a> to generate
Semantic Conventions markdown or code.</p>
</li>
<li>
<p><code>feature_flag</code>: Move the evaluated value from the event
body to attributes (<a
href="open-telemetry/semantic-conventions#1990"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1990/hovercard">#1990</a>)</p>
</li>
<li>
<p><code>process</code>: Require sensitive data sanitization for
<code>process.command_args</code> and <code>process.command_line</code>
(<a
href="open-telemetry/semantic-conventions#626"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/626/hovercard">#626</a>)</p>
</li>
</ul>
<h3>💡 Enhancements 💡</h3>
<ul>
<li><code>docs</code>: Document system-specific naming conventions (<a
href="open-telemetry/semantic-conventions#608"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/608/hovercard">#608</a>,
<a
href="open-telemetry/semantic-conventions#1494"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1494/hovercard">#1494</a>,
<a
href="open-telemetry/semantic-conventions#1708"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1708/hovercard">#1708</a>)</li>
<li><code>gen-ai</code>: Add <code>gen_ai.conversation.id</code>
attribute (<a
href="open-telemetry/semantic-conventions#2024"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2024/hovercard">#2024</a>)</li>
<li><code>all</code>: Renames all <code>resource.*</code> groups to be
<code>entity.*</code> (<a
href="open-telemetry/semantic-conventions#2244"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2244/hovercard">#2244</a>)<br>
Part of <a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2885075816" data-permission-text="Title is private"
data-url="open-telemetry/opentelemetry-specification#4436"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/opentelemetry-specification/issues/4436/hovercard"
href="https://github.com/open-telemetry/opentelemetry-specification/issues/4436">open-telemetry/opentelemetry-specification#4436</a></li>
<li><code>aws</code>: Added new AWS attributes for various services
including SQS, SNS, Bedrock, Step Functions, Secrets Manager and Kineses
(<a
href="open-telemetry/semantic-conventions#1794"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1794/hovercard">#1794</a>)</li>
<li><code>cloud</code>: Broaden <code>cloud.region</code> definition to
explicitly cover both resource location and targeted destination. (<a
href="open-telemetry/semantic-conventions#2142"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2142/hovercard">#2142</a>)</li>
<li><code>network</code>: Stabilize <code>network.transport</code> enum
value <code>quic</code>. (<a
href="open-telemetry/semantic-conventions#2275"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2275/hovercard">#2275</a>)</li>
</ul>
<h3>🧰 Bug fixes 🧰</h3>
<ul>
<li><code>db</code>: Fix the <code>db.system.name</code> attribute value
for MySQL which was incorrectly pointing to
<code>microsoft.sql_server</code>. (<a
href="open-telemetry/semantic-conventions#2276"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2276/hovercard">#2276</a>)</li>
</ul>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsuereth jsuereth jsuereth approved these changes

@lmolkova lmolkova lmolkova approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@arminru arminru arminru approved these changes

Assignees

No one assigned

Labels

area:network enhancement New feature or request

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trask @jsuereth @lmolkova @joaopgrassi @arminru