Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix what can be modified via ReadWriteLogRecord #3907

Merged
merged 21 commits into from
Mar 28, 2024
Merged

Fix what can be modified via ReadWriteLogRecord #3907

merged 21 commits into from
Mar 28, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Feb 27, 2024 •
edited
Loading

Fixes #3902

Changes

Fix what can be modified via ReadWriteLogRecord.

@pellared pellared changed the title Clarify what LogRecordProcessor is able to modify Explicitly define what can be modified via ReadWriteLogRecord Feb 27, 2024
@pellared pellared changed the title Explicitly define what can be modified via ReadWriteLogRecord Fix what can be modified via ReadWriteLogRecord Feb 27, 2024
@pellared pellared mentioned this pull request Feb 27, 2024
Closed
@pellared pellared marked this pull request as ready for review February 27, 2024 09:34
@pellared pellared requested review from a team February 27, 2024 09:34
MrAlias
MrAlias reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this change, but how are we going to account for the SIGs that have implemented modification of more than the information added via Emit?

@pellared
Copy link
Member Author

I support this change, but how are we going to account for the SIGs that have implemented modification of more than the information added via Emit?

PTAL @open-telemetry/cpp-maintainers

Maybe C++ SIG could deprecate the methods, change its behavior to be no-op (no operation) and update the documentation accordingly?

pellared
pellared commented Feb 29, 2024
View reviewed changes
specification/logs/sdk.md Outdated Show resolved Hide resolved
@pellared pellared mentioned this pull request Mar 7, 2024
Merged
jack-berg
jack-berg approved these changes Mar 15, 2024
View reviewed changes
specification/logs/sdk.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 23, 2024
@pellared pellared mentioned this pull request Mar 27, 2024
Merged
@carlosalberto carlosalberto merged commit 40aaf16 into open-telemetry:main Mar 28, 2024
7 checks passed
@brettmc brettmc mentioned this pull request Apr 29, 2024
Open
4 tasks
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@pellared
Fix what can be modified via ReadWriteLogRecord (open-telemetry#3907)
e83e272 
Fixes
open-telemetry#3902

## Changes

Fix what can be modified via `ReadWriteLogRecord`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

@jmacd jmacd jmacd approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees

@jack-berg jack-berg

Labels
None yet
Projects
Go: Logs (GA)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify what LogRecordProcessor is able to modify
6 participants
@pellared @carlosalberto @jmacd @cijothomas @MrAlias @jack-berg