Skip to content

Commit

Permalink
Fix what can be modified via ReadWriteLogRecord (#3907)
Browse files Browse the repository at this point in the history
Fixes
#3902

## Changes

Fix what can be modified via `ReadWriteLogRecord`.
  • Loading branch information
pellared authored Mar 28, 2024
1 parent 98e1344 commit 40aaf16
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ release.
([#3855](https://github.com/open-telemetry/opentelemetry-specification/pull/3855))
- Clarify that `ReadableLogRecord` and `ReadWriteLogRecord` can be represented using a single type.
([#3898](https://github.com/open-telemetry/opentelemetry-specification/pull/3898))
- Fix what can be modified via `ReadWriteLogRecord`.
([#3907](https://github.com/open-telemetry/opentelemetry-specification/pull/3907))

### Events

Expand Down
19 changes: 14 additions & 5 deletions specification/logs/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,20 @@ and `ReadWriteLogRecord`.

### ReadWriteLogRecord

A function receiving this as an argument MUST be able to write to the
full [LogRecord](data-model.md#log-and-event-record-definition) and additionally MUST be able to retrieve all
information
that was added to the `LogRecord` (as with
[ReadableLogRecord](#readablelogrecord)).
ReadWriteLogRecord is a superset of [ReadableLogRecord](#readablelogrecord).

A function receiving this as an argument MUST additionally be able to modify
the following information added to the [LogRecord](data-model.md#log-and-event-record-definition):

* [`Timestamp`](./data-model.md#field-timestamp)
* [`ObservedTimestamp`](./data-model.md#field-observedtimestamp)
* [`SeverityText`](./data-model.md#field-severitytext)
* [`SeverityNumber`](./data-model.md#field-severitynumber)
* [`Body`](./data-model.md#field-body)
* [`Attributes`](./data-model.md#field-attributes) (addition, modification, removal)
* [`TraceId`](./data-model.md#field-traceid)
* [`SpanId`](./data-model.md#field-spanid)
* [`TraceFlags`](./data-model.md#field-traceflags)

## LogRecord Limits

Expand Down

0 comments on commit 40aaf16

Please sign in to comment.